fix(eslint-plugin): [embt] ignore JSX callbacks (typescript-eslint#1630)

a-tarasyuk · web-flow · commit 4d45b331b920 · 2020-02-24T09:21:43.000-08:00
diff --git a/packages/eslint-plugin/src/rules/explicit-module-boundary-types.ts b/packages/eslint-plugin/src/rules/explicit-module-boundary-types.ts
@@ -79,6 +79,10 @@ export default util.createRule<Options, MessageIds>({
           return false;
         }
 
+        if (node.type === AST_NODE_TYPES.JSXExpressionContainer) {
+          return true;
+        }
+
         if (node.type === AST_NODE_TYPES.ReturnStatement) {
           isReturnedValue = true;
         }
diff --git a/packages/eslint-plugin/tests/rules/explicit-module-boundary-types.test.ts b/packages/eslint-plugin/tests/rules/explicit-module-boundary-types.test.ts
@@ -312,6 +312,35 @@ export class Test {
         },
       ],
     },
+    {
+      code: `
+export const Foo: FC = () => (
+  <div
+    a={e => {}}
+    b={function (e) {}}
+    c={function foo(e) {}}
+  >
+  </div>
+)
+      `,
+      parserOptions: {
+        ecmaFeatures: { jsx: true },
+      },
+    },
+    {
+      code: `
+export const Foo: JSX.Element =
+  <div
+    a={e => {}}
+    b={function (e) {}}
+    c={function foo(e) {}}
+  >
+  </div>
+      `,
+      parserOptions: {
+        ecmaFeatures: { jsx: true },
+      },
+    },
   ],
   invalid: [
     {

Original file line number	Diff line number	Diff line change
`@@ -79,6 +79,10 @@ export default util.createRule<Options, MessageIds>({`
`79`	`79`	`return false;`
`80`	`80`	`}`
`81`	`81`
	`82`	`+ if (node.type === AST_NODE_TYPES.JSXExpressionContainer) {`
	`83`	`+ return true;`
	`84`	`+ }`
	`85`	`+`
`82`	`86`	`if (node.type === AST_NODE_TYPES.ReturnStatement) {`
`83`	`87`	`isReturnedValue = true;`
`84`	`88`	`}`