ci: add node 24 RC to test matrices

serhalp · serhalp · commit c502d6b1432b · 2025-04-15T18:26:02.000-04:00
It's going stable on April 30 2025.
diff --git a/.github/workflows/e2e-tests.yml b/.github/workflows/e2e-tests.yml
@@ -20,8 +20,7 @@ jobs:
     strategy:
       matrix:
         os: [windows-latest]
-        # Pinning 20.x version as a temporary workaround due to this https://github.com/nodejs/node/issues/52884
-        node-version: ['18.14.0', '20.12.2', '22']
+        node-version: ['18.14.0', '20', '22', '24-rc.2']
       fail-fast: false
     steps:
       # This improves Windows network performance. We need this since we open many ports in our tests.
@@ -79,7 +78,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest, macOS-latest]
-        node-version: ['18.14.0', '*']
+        node-version: ['18.14.0', '22', '24-rc.2']
       fail-fast: false
     steps:
       - name: Git checkout
diff --git a/.github/workflows/integration-tests.yml b/.github/workflows/integration-tests.yml
@@ -18,10 +18,11 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest, macOS-latest, windows-latest]
-        # Pinning 20.x version as a temporary workaround due to this https://github.com/nodejs/node/issues/52884
-        node-version: ['18.17.0', '20.12.2', '22']
+        # TODO(serhalp): Document why we test against 18.17.0 here (18.14.0 is our minimum supported version)
+        node-version: ['18.17.0', '20', '22', '24-rc.2']
         shard: ['1/4', '2/4', '3/4', '4/4']
 
+        # TODO(serhalp): Why are these excluded? Document, fix, or remove.
         exclude:
           - os: macOS-latest
             node-version: '18.17.0'
@@ -113,87 +114,3 @@ jobs:
         with:
           flags: ${{ steps.test-coverage-flags.outputs.os }},${{ steps.test-coverage-flags.outputs.node }}
           token: ${{ secrets.CODECOV_TOKEN }}
-  # Specific tests for known test that failed on windows using node 23.
-  # Can be replaced with larger node 23 tests in the future.
-  integration-win-node-23:
-    name: Integration test windows latest node23 specific
-    runs-on: windows-latest
-    timeout-minutes: 40
-    steps:
-      # This improves Windows network performance, we need this since we open many ports in our tests
-      - name: Increase Windows port limit and reduce time wait delay
-        run: |
-          netsh int ipv4 set dynamicport tcp start=1025 num=64511
-          REG ADD HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Services\TCPIP\Parameters /v TcpTimedWaitDelay /t REG_DWORD /d 30 /f
-
-      - name: Git checkout
-        uses: actions/checkout@v4
-        with:
-          fetch-depth: 0
-
-      - name: Use Node.js
-        uses: actions/setup-node@v4
-        with:
-          node-version: '23.x'
-          cache: npm
-          check-latest: true
-
-      - name: Install PNPM
-        run: |
-          corepack enable
-          corepack prepare pnpm@9.14.2 --activate
-
-      - name: Setup Deno
-        uses: denoland/setup-deno@v1
-        with:
-          deno-version: v1.44.4
-
-      - name: Install core dependencies
-        run: npm ci --no-audit
-
-      - name: Build project
-        run: npm run build
-        if: '${{!steps.release-check.outputs.IS_RELEASE}}'
-
-      - name: Prepare tests
-        run: npm run test:init
-
-      - name: Tests
-        run: npm exec vitest -- run tests/integration/commands/dev/dev.test.ts --coverage
-        env:
-          # GitHub secrets are not available when running on PR from forks
-          # We set a flag so we can skip tests that access Netlify API
-          NETLIFY_TEST_DISABLE_LIVE:
-            ${{ github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork == true }}
-          NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_AUTH_TOKEN }}
-          # NETLIFY_TEST_GITHUB_TOKEN is used to avoid reaching GitHub API limits in exec-fetcher.js
-          NETLIFY_TEST_GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          # Changes the polling interval used by the file watcher
-          CHOKIDAR_INTERVAL: 20
-          CHOKIDAR_USEPOLLING: 1
-
-      - name: Get test coverage flags
-        id: test-coverage-flags
-        # For windows we have to use $env:
-        run: |-
-          os=windows-latest
-          node=$(node --version)
-          echo "os=${os/-latest/}" >> $GITHUB_OUTPUT
-          echo "os=${os/-latest/}" >> $env:GITHUB_OUTPUT
-          echo "node=node_${node/.*.*/}" >> $GITHUB_OUTPUT
-          echo "node=node_${node/.*.*/}" >> $env:GITHUB_OUTPUT
-        shell: bash
-
-      - name: Store npm error artefacts
-        uses: actions/upload-artifact@v4
-        if: always()
-        with:
-          name: npm-logs--windows-latest--23x
-          path: |
-            ~/.npm/_logs/**/*
-
-      - uses: codecov/codecov-action@v5
-        continue-on-error: true
-        with:
-          flags: ${{ steps.test-coverage-flags.outputs.os }},${{ steps.test-coverage-flags.outputs.node }}
-          token: ${{ secrets.CODECOV_TOKEN }}
diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml
@@ -17,10 +17,11 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest, macOS-latest, windows-latest]
-        node-version: ['18.14.0', '22.x']
+        node-version: ['18.14.0', '22', '24-rc.2']
+        # TODO(serhalp): Why is this excluded? Document, fix, or remove.
         exclude:
           - os: windows-latest
-            node-version: '22.x'
+            node-version: '22'
       fail-fast: false
     steps:
       - name: Git checkout
