-
Notifications
You must be signed in to change notification settings - Fork 504
refactor: 💡 convert prototype to class #728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👍🏼 Looks like this doesn't cause any new test failures. |
I'm in favor of merging this, but would like to get #704 resolved first. You are welcome to take a look if you'd like. |
This appears to conflict with your other PR. I'll merge it when the conflicts are resolved. |
# Conflicts: # lib/config.js
Hi sir! I've resolved all the conflicts! I believe it should be good to go now! 💪 😊 |
I would love to get util factored completely out, but it is stateful in a couple of places that make that tricky. this might be a step toward that eventuality, or at least it doesn’t seem to make things worse.. LGTM |
I think we could also start using nullish operators, but that would necessitate bumping to node 14 and trunk is still on 10.0.0 |
@markstos can we land this in 3.x or should this be 4.0? |
@jdmarshall It's /probably/ not breaking, but as we are making good progress towards 4.0. But since I think 4.0 will be the next release, we can go ahead and merge. |
I got a merge conflict when I tried to rebase to see if this was still viable. util is a very very weird class. maybe making it into a Class doesn't change that for better or worse. |
Converting back to draft as there are conflicts to resolve again. |
I may try to land this after #816 |
I'm now thinking this would be a good candidate for 4.2. I'm hoping to remove most of the deprecated forwarding functions in config.js then, which will make this change have less to touch. |
Hi there!
I convert the prototype-based implementation to a class-based implementation! Please have a look!