Skip to content

Commit bb2977c

Browse files
richardlauaduh95
authored andcommitted
build: use glob for dependencies of out/Makefile
The `out/Makefile` target in `Makefile` has an incomplete list of `.gyp` files for Node.js dependencies in `deps`, but also the ones that are listed are unconditional. If using any of the `--shared-*` configure options, it should be possible to still build Node.js if the corresponding directory under `deps` is removed. Convert the explicit list of dependency `*.gyp` files for the `out/Makefile` target to a glob. This will pick up any toplevel `.gyp` files for dependencies present in `deps`. PR-URL: #55789 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
1 parent b08ce67 commit bb2977c

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

Makefile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -170,9 +170,9 @@ with-code-cache test-code-cache:
170170
$(warning '$@' target is a noop)
171171

172172
out/Makefile: config.gypi common.gypi node.gyp \
173-
deps/uv/uv.gyp deps/llhttp/llhttp.gyp deps/zlib/zlib.gyp \
174-
deps/simdutf/simdutf.gyp deps/ada/ada.gyp \
175-
tools/v8_gypfiles/toolchain.gypi tools/v8_gypfiles/features.gypi \
173+
deps/*/*.gyp \
174+
tools/v8_gypfiles/toolchain.gypi \
175+
tools/v8_gypfiles/features.gypi \
176176
tools/v8_gypfiles/inspector.gypi tools/v8_gypfiles/v8.gyp
177177
$(PYTHON) tools/gyp_node.py -f make
178178

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy