always show the latest version of nvm

ljharb · ljharb · commit 13ae34df04a7 · 2024-11-29T21:41:27.000-08:00
diff --git a/apps/site/components/Downloads/Release/ReleaseCodeBox.tsx b/apps/site/components/Downloads/Release/ReleaseCodeBox.tsx
@@ -22,7 +22,7 @@ const ReleaseCodeBox: FC = () => {
 
   useEffect(() => {
     const updatedCode = getNodeDownloadSnippet(release, os, t)[platform];
-    // Docker and NVM support downloading tags/versions by their full release number
+    // Docker and nvm support downloading tags/versions by their full release number
     // but usually we should recommend users to download "major" versions
     // since our Download Buttons get the latest minor of a major, it does make sense
     // to request installation of a major via a package manager
diff --git a/apps/site/util/getNodeDownloadSnippet.ts b/apps/site/util/getNodeDownloadSnippet.ts
@@ -5,11 +5,23 @@ import type { NodeRelease } from '@/types';
 import type { PackageManager } from '@/types/release';
 import type { UserOS } from '@/types/userOS';
 
-export const getNodeDownloadSnippet = (
+const latestVersion = fetch('https://latest.nvm.sh', { redirect: 'manual' })
+  .then(({ headers }) => {
+    const url = headers.get('location');
+    if (!url) { throw null; }
+    return fetch(url, { redirect: 'manual' });
+  })
+  .then(x => {
+    const url = x.headers.get('location');
+    return url?.slice(url?.lastIndexOf('/'));
+  })
+  .catch(() => 'v0.40.1');
+
+export async function getNodeDownloadSnippet(
   release: NodeRelease,
   os: UserOS,
   t: (key: string, values?: TranslationValues) => string
-) => {
+) {
   const snippets: Record<PackageManager, string> = {
     NVM: '',
     FNM: '',
@@ -37,9 +49,10 @@ export const getNodeDownloadSnippet = (
   }
 
   if (os === 'MAC' || os === 'LINUX') {
+
     snippets.NVM = dedent`
       # ${t('layouts.download.codeBox.installsNvm')}
-      curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.0/install.sh | bash
+      curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/${await latestVersion}/install.sh | bash
 
       # ${t('layouts.download.codeBox.downloadAndInstallNodejsRestartTerminal')}
       nvm install ${release.major}
