fix: remove unused parameters catch statements (#7795)

btea · web-flow · commit 534ad7789e5c · 2024-10-03T11:15:15.000-07:00
diff --git a/lib/commands/cache.js b/lib/commands/cache.js
@@ -38,7 +38,7 @@ const searchCachePackage = async (path, parsed, cacheKeys) => {
     try {
       details = await cacache.get(path, key)
       packument = jsonParse(details.data)
-    } catch (_) {
+    } catch {
       // if we couldn't parse the packument, abort
       continue
     }
@@ -131,7 +131,7 @@ class Cache extends BaseCommand {
       let entry
       try {
         entry = await cacache.get(cachePath, key)
-      } catch (err) {
+      } catch {
         log.warn('cache', `Not Found: ${key}`)
         break
       }
diff --git a/lib/commands/diff.js b/lib/commands/diff.js
@@ -83,7 +83,7 @@ class Diff extends BaseCommand {
     try {
       const { content: pkg } = await pkgJson.normalize(this.prefix)
       name = pkg.name
-    } catch (e) {
+    } catch {
       log.verbose('diff', 'could not read project dir package.json')
     }
 
@@ -117,7 +117,7 @@ class Diff extends BaseCommand {
     try {
       const { content: pkg } = await pkgJson.normalize(this.prefix)
       pkgName = pkg.name
-    } catch (e) {
+    } catch {
       log.verbose('diff', 'could not read project dir package.json')
       noPackageJson = true
     }
@@ -156,7 +156,7 @@ class Diff extends BaseCommand {
         node = actualTree &&
           actualTree.inventory.query('name', spec.name)
             .values().next().value
-      } catch (e) {
+      } catch {
         log.verbose('diff', 'failed to load actual install tree')
       }
 
@@ -230,7 +230,7 @@ class Diff extends BaseCommand {
       try {
         const { content: pkg } = await pkgJson.normalize(this.prefix)
         pkgName = pkg.name
-      } catch (e) {
+      } catch {
         log.verbose('diff', 'could not read project dir package.json')
       }
 
@@ -265,7 +265,7 @@ class Diff extends BaseCommand {
       }
       const arb = new Arborist(opts)
       actualTree = await arb.loadActual(opts)
-    } catch (e) {
+    } catch {
       log.verbose('diff', 'failed to load actual install tree')
     }
 
diff --git a/lib/commands/dist-tag.js b/lib/commands/dist-tag.js
@@ -182,7 +182,7 @@ class DistTag extends BaseCommand {
       try {
         output.standard(`${name}:`)
         await this.list(npa(name), this.npm.flatOptions)
-      } catch (err) {
+      } catch {
         // set the exitCode directly, but ignore the error
         // since it will have already been logged by this.list()
         process.exitCode = 1
diff --git a/lib/commands/doctor.js b/lib/commands/doctor.js
@@ -246,7 +246,7 @@ class Doctor extends BaseCommand {
 
         try {
           await access(f, mask)
-        } catch (er) {
+        } catch {
           ok = false
           const msg = `Missing permissions on ${f} (expect: ${maskLabel(mask)})`
           log.error('doctor', 'checkFilesPermission', msg)
diff --git a/lib/commands/explain.js b/lib/commands/explain.js
@@ -109,7 +109,7 @@ class Explain extends ArboristWorkspaceCmd {
     // otherwise, try to select all matching nodes
     try {
       return this.getNodesByVersion(tree, arg)
-    } catch (er) {
+    } catch {
       return []
     }
   }
diff --git a/lib/commands/init.js b/lib/commands/init.js
@@ -192,7 +192,7 @@ class Init extends BaseCommand {
     // top-level package.json
     try {
       statSync(resolve(workspacePath, 'package.json'))
-    } catch (err) {
+    } catch {
       return
     }
 
diff --git a/lib/commands/install.js b/lib/commands/install.js
@@ -68,7 +68,7 @@ class Install extends ArboristWorkspaceCmd {
           const contents = await readdir(join(partialPath, sibling))
           const result = (contents.indexOf('package.json') !== -1)
           return result
-        } catch (er) {
+        } catch {
           return false
         }
       }
@@ -86,7 +86,7 @@ class Install extends ArboristWorkspaceCmd {
         }
         // no matches
         return []
-      } catch (er) {
+      } catch {
         return [] // invalid dir: no matching
       }
     }
diff --git a/lib/commands/ls.js b/lib/commands/ls.js
@@ -233,7 +233,7 @@ const isGitNode = (node) => {
   try {
     const { type } = npa(node.resolved)
     return type === 'git' || type === 'hosted'
-  } catch (err) {
+  } catch {
     return false
   }
 }
diff --git a/lib/commands/repo.js b/lib/commands/repo.js
@@ -49,7 +49,7 @@ const unknownHostedUrl = url => {
     const proto = /(git\+)http:$/.test(protocol) ? 'http:' : 'https:'
     const path = pathname.replace(/\.git$/, '')
     return `${proto}//${hostname}${path}`
-  } catch (e) {
+  } catch {
     return null
   }
 }
diff --git a/lib/utils/sbom-cyclonedx.js b/lib/utils/sbom-cyclonedx.js
@@ -94,7 +94,7 @@ const toCyclonedxItem = (node, { packageType }) => {
     }
 
     parsedLicense = parseLicense(license)
-  } catch (err) {
+  } catch {
     parsedLicense = null
   }
 
@@ -192,7 +192,7 @@ const isGitNode = (node) => {
   try {
     const { type } = npa(node.resolved)
     return type === 'git' || type === 'hosted'
-  } catch (err) {
+  } catch {
     /* istanbul ignore next */
     return false
   }
diff --git a/lib/utils/sbom-spdx.js b/lib/utils/sbom-spdx.js
@@ -173,7 +173,7 @@ const isGitNode = (node) => {
   try {
     const { type } = npa(node.resolved)
     return type === 'git' || type === 'hosted'
-  } catch (err) {
+  } catch {
     /* istanbul ignore next */
     return false
   }

Original file line number	Diff line number	Diff line change
`@@ -109,7 +109,7 @@ class Explain extends ArboristWorkspaceCmd {`
`109`	`109`	`// otherwise, try to select all matching nodes`
`110`	`110`	`try {`
`111`	`111`	`return this.getNodesByVersion(tree, arg)`
`112`		`- } catch (er) {`
	`112`	`+ } catch {`
`113`	`113`	`return []`
`114`	`114`	`}`
`115`	`115`	`}`
Original file line number	Diff line number	Diff line change
`@@ -192,7 +192,7 @@ class Init extends BaseCommand {`
`192`	`192`	`// top-level package.json`
`193`	`193`	`try {`
`194`	`194`	`statSync(resolve(workspacePath, 'package.json'))`
`195`		`- } catch (err) {`
	`195`	`+ } catch {`
`196`	`196`	`return`
`197`	`197`	`}`
`198`	`198`
Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ class Install extends ArboristWorkspaceCmd {`
`68`	`68`	`const contents = await readdir(join(partialPath, sibling))`
`69`	`69`	`const result = (contents.indexOf('package.json') !== -1)`
`70`	`70`	`return result`
`71`		`- } catch (er) {`
	`71`	`+ } catch {`
`72`	`72`	`return false`
`73`	`73`	`}`
`74`	`74`	`}`
`@@ -86,7 +86,7 @@ class Install extends ArboristWorkspaceCmd {`
`86`	`86`	`}`
`87`	`87`	`// no matches`
`88`	`88`	`return []`
`89`		`- } catch (er) {`
	`89`	`+ } catch {`
`90`	`90`	`return [] // invalid dir: no matching`
`91`	`91`	`}`
`92`	`92`	`}`
Original file line number	Diff line number	Diff line change
`@@ -233,7 +233,7 @@ const isGitNode = (node) => {`
`233`	`233`	`try {`
`234`	`234`	`const { type } = npa(node.resolved)`
`235`	`235`	`return type === 'git' \|\| type === 'hosted'`
`236`		`- } catch (err) {`
	`236`	`+ } catch {`
`237`	`237`	`return false`
`238`	`238`	`}`
`239`	`239`	`}`
Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ const unknownHostedUrl = url => {`
`49`	`49`	`const proto = /(git\+)http:$/.test(protocol) ? 'http:' : 'https:'`
`50`	`50`	`const path = pathname.replace(/\.git$/, '')`
`51`	`51`	return `${proto}//${hostname}${path}`
`52`		`- } catch (e) {`
	`52`	`+ } catch {`
`53`	`53`	`return null`
`54`	`54`	`}`
`55`	`55`	`}`
Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,7 @@ const toCyclonedxItem = (node, { packageType }) => {`
`94`	`94`	`}`
`95`	`95`
`96`	`96`	`parsedLicense = parseLicense(license)`
`97`		`- } catch (err) {`
	`97`	`+ } catch {`
`98`	`98`	`parsedLicense = null`
`99`	`99`	`}`
`100`	`100`
`@@ -192,7 +192,7 @@ const isGitNode = (node) => {`
`192`	`192`	`try {`
`193`	`193`	`const { type } = npa(node.resolved)`
`194`	`194`	`return type === 'git' \|\| type === 'hosted'`
`195`		`- } catch (err) {`
	`195`	`+ } catch {`
`196`	`196`	`/* istanbul ignore next */`
`197`	`197`	`return false`
`198`	`198`	`}`
Original file line number	Diff line number	Diff line change
`@@ -173,7 +173,7 @@ const isGitNode = (node) => {`
`173`	`173`	`try {`
`174`	`174`	`const { type } = npa(node.resolved)`
`175`	`175`	`return type === 'git' \|\| type === 'hosted'`
`176`		`- } catch (err) {`
	`176`	`+ } catch {`
`177`	`177`	`/* istanbul ignore next */`
`178`	`178`	`return false`
`179`	`179`	`}`