feat!: adds --ignore-scripts flag to pack

reggi · wraithgar · commit 6995303687ab · 2024-11-21T13:25:28.000-08:00
BREAKING CHANGE: `--ignore-scripts` now applies to all lifecycle scripts, include `prepare`
diff --git a/lib/commands/pack.js b/lib/commands/pack.js
@@ -15,6 +15,7 @@ class Pack extends BaseCommand {
     'workspace',
     'workspaces',
     'include-workspace-root',
+    'ignore-scripts',
   ]
 
   static usage = ['<package-spec>']
diff --git a/tap-snapshots/test/lib/docs.js.test.cjs b/tap-snapshots/test/lib/docs.js.test.cjs
@@ -3680,7 +3680,7 @@ npm pack <package-spec>
 Options:
 [--dry-run] [--json] [--pack-destination <pack-destination>]
 [-w|--workspace <workspace-name> [-w|--workspace <workspace-name> ...]]
-[-ws|--workspaces] [--include-workspace-root]
+[-ws|--workspaces] [--include-workspace-root] [--ignore-scripts]
 
 Run "npm help pack" for more info
 
@@ -3694,6 +3694,7 @@ npm pack <package-spec>
 #### \`workspace\`
 #### \`workspaces\`
 #### \`include-workspace-root\`
+#### \`ignore-scripts\`
 `
 
 exports[`test/lib/docs.js TAP usage ping > must match snapshot 1`] = `
diff --git a/workspaces/arborist/lib/arborist/rebuild.js b/workspaces/arborist/lib/arborist/rebuild.js
@@ -154,7 +154,9 @@ module.exports = cls => class Builder extends cls {
 
     // links should run prepare scripts and only link bins after that
     if (type === 'links') {
-      await this.#runScripts('prepare')
+      if (!this.options.ignoreScripts) {
+        await this.#runScripts('prepare')
+      }
     }
     if (this.options.binLinks) {
       await this.#linkAllBins()
diff --git a/workspaces/arborist/test/arborist/rebuild.js b/workspaces/arborist/test/arborist/rebuild.js
@@ -812,3 +812,38 @@ t.test('no workspaces', async t => {
     },
   ])
 })
+
+t.test('do not run lifecycle scripts of linked deps twice', async t => {
+  const testdir = t.testdir({
+    project: {
+      'package.json': JSON.stringify({
+        name: 'my-project',
+        version: '1.0.0',
+        dependencies: {
+          foo: 'file:../foo',
+        },
+      }),
+      node_modules: {
+        foo: t.fixture('symlink', '../../foo'),
+      },
+    },
+    foo: {
+      'package.json': JSON.stringify({
+        name: 'foo',
+        version: '1.0.0',
+        scripts: {
+          postinstall: 'echo "ok"',
+        },
+      }),
+    },
+  })
+
+  const path = resolve(testdir, 'project')
+  const Arborist = t.mock('../../lib/arborist/index.js', {
+    '@npmcli/run-script': () => {
+      throw new Error('should not run any scripts')
+    },
+  })
+  const arb = new Arborist({ path, ignoreScripts: true })
+  await arb.rebuild()
+})

Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,7 @@ class Pack extends BaseCommand {`
`15`	`15`	`'workspace',`
`16`	`16`	`'workspaces',`
`17`	`17`	`'include-workspace-root',`
	`18`	`+ 'ignore-scripts',`
`18`	`19`	`]`
`19`	`20`
`20`	`21`	`static usage = ['<package-spec>']`