BUG: avoid segmentation fault in string_expandtabs_length_promoter

riku-sakamoto · riku-sakamoto · commit 13d91c7e1437 · 2025-07-13T09:15:47.000-07:00
Fixes the first item in #28829. `op_dtypes[0]` may be null, so use `op_dtypes[1]` instead.
diff --git a/numpy/_core/src/umath/string_ufuncs.cpp b/numpy/_core/src/umath/string_ufuncs.cpp
@@ -941,8 +941,8 @@ string_expandtabs_length_promoter(PyObject *NPY_UNUSED(ufunc),
         PyArray_DTypeMeta *const op_dtypes[], PyArray_DTypeMeta *const signature[],
         PyArray_DTypeMeta *new_op_dtypes[])
 {
-    Py_INCREF(op_dtypes[0]);
-    new_op_dtypes[0] = op_dtypes[0];
+    Py_INCREF(op_dtypes[1]);
+    new_op_dtypes[0] = op_dtypes[1];
     new_op_dtypes[1] = NPY_DT_NewRef(&PyArray_Int64DType);
     new_op_dtypes[2] = PyArray_DTypeFromTypeNum(NPY_DEFAULT_INT);
     return 0;
