fix(modal): switch to dialog element #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aesteves60
suggested changes
Nov 22, 2023
packages/components/modal/src/components/osds-modal/osds-modal.spec.ts
Outdated
Show resolved
Hide resolved
packages/components/modal/src/components/osds-modal/osds-modal.tsx
Outdated
Show resolved
Hide resolved
packages/components/modal/src/components/osds-modal/osds-modal.tsx
Outdated
Show resolved
Hide resolved
packages/components/modal/src/components/osds-modal/styles/osds-modal.color.scss
Outdated
Show resolved
Hide resolved
aesteves60
approved these changes
Nov 23, 2023
skhamvon
approved these changes
Nov 23, 2023
astagnol
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OsdsModalis now using aHTMLDialogElementand is no longer appended to the body. (fixes react children problem)OsdsModalis now reactive toEscapekey. (will close the modal if dismissible)OsdsModal's icon has been fixed and no longer features a colored background.