BUG: Return NotImplemented for non-1D operands in BooleanArray ops; add tests for numeric EA shape errors

tisjayy · tisjayy · commit f9cb022067e2 · 2025-07-29T01:03:51.000-04:00
diff --git a/pandas/core/arrays/boolean.py b/pandas/core/arrays/boolean.py
@@ -379,7 +379,7 @@ def _logical_method(self, other, op):  # type: ignore[override]
         elif is_list_like(other):
             other = np.asarray(other, dtype="bool")
             if other.ndim > 1:
-                raise NotImplementedError("can only perform ops with 1-d structures")
+                return NotImplemented 
             other, mask = coerce_to_array(other, copy=False)
         elif isinstance(other, np.bool_):
             other = other.item()
diff --git a/pandas/tests/arithmetic/test_numeric.py b/pandas/tests/arithmetic/test_numeric.py
@@ -564,6 +564,8 @@ def test_df_div_zero_series_does_not_commute(self):
         res2 = df / ser
         assert not res.fillna(0).equals(res2.fillna(0))
 
+    
+
     # ------------------------------------------------------------------
     # Mod By Zero
 
@@ -855,6 +857,35 @@ def test_modulo_zero_int(self):
             result = 0 % s
             expected = Series([np.nan, 0.0])
             tm.assert_series_equal(result, expected)
+    
+    def test_np_array_mul_ea_array_returns_extensionarray():
+        np_array = np.array([1, 2, 3, 4, 5], dtype=tm.SIGNED_INT_NUMPY_DTYPES[0])
+        ea_array = pd.array([1, 2, 3, 4, 5], dtype=tm.SIGNED_INT_EA_DTYPES[0])
+        result = np_array * ea_array
+        tm.assert_isinstance(result, type(ea_array))
+        tm.assert_equal(result, pd.array([1, 4, 9, 16, 25], dtype=tm.SIGNED_INT_EA_DTYPES[0]))
+        tm.assert_equal(result, pd.array([1, 4, 9, 16, 25], dtype=tm.SIGNED_INT_EA_DTYPES[0]))
+
+    def test_df_mul_np_and_ea_array_shape_and_errors():
+        df = pd.DataFrame(np.arange(50).reshape(10, 5)).notna().values
+        NP_array = pd.array([i for i in range(10)], dtype=tm.SIGNED_INT_NUMPY_DTYPES[0]).reshape(10, 1)
+        EA_array = pd.array([i for i in range(10)], dtype=tm.SIGNED_INT_EA_DTYPES[0]).reshape(10, 1)
+        
+        result_np = df * NP_array
+        tm.assert_isinstance(result_np, np.ndarray)
+        tm.assert_equal(result_np.shape, (10, 5))
+
+        with tm.assert_raises(TypeError):
+             _ = df * EA_array
+
+    def test_non_1d_ea_raises_typeerror():
+        ea_array = pd.array([1, 2, 3, 4, 5], dtype=tm.SIGNED_INT_EA_DTYPES[0]).reshape(5, 1)
+        np_array = np.array([1, 2, 3, 4, 5], dtype=tm.SIGNED_INT_NUMPY_DTYPES[0]).reshape(5, 1)
+
+        with tm.assert_raises(TypeError):
+            _ = ea_array * np_array
+        with tm.assert_raises(TypeError):
+             _ = np_array * ea_array
 
 
 class TestAdditionSubtraction:
