extmod/vfs_posix_file: Ensure file object has safe default fd.

pi-anl · dpgeorge · commit 2962e24167a7 · 2024-02-21T09:51:52.000+11:00
With this commit, if file open fails, the object will have fd = -1 (closed) and the finaliser will not attempt to close anything. Fixes issue micropython#13672. Signed-off-by: Andrew Leech <andrew.leech@planetinnovation.com.au>
diff --git a/extmod/vfs_posix_file.c b/extmod/vfs_posix_file.c
@@ -92,6 +92,7 @@ mp_obj_t mp_vfs_posix_file_open(const mp_obj_type_t *type, mp_obj_t file_in, mp_
     }
 
     mp_obj_vfs_posix_file_t *o = mp_obj_malloc_with_finaliser(mp_obj_vfs_posix_file_t, type);
+    o->fd = -1; // In case open() fails below, initialise this as a "closed" file object.
 
     mp_obj_t fid = file_in;
 

Original file line number	Diff line number	Diff line change
`@@ -92,6 +92,7 @@ mp_obj_t mp_vfs_posix_file_open(const mp_obj_type_t *type, mp_obj_t file_in, mp_`
`92`	`92`	`}`
`93`	`93`
`94`	`94`	`mp_obj_vfs_posix_file_t *o = mp_obj_malloc_with_finaliser(mp_obj_vfs_posix_file_t, type);`
	`95`	`+ o->fd = -1; // In case open() fails below, initialise this as a "closed" file object.`
`95`	`96`
`96`	`97`	`mp_obj_t fid = file_in;`
`97`	`98`