-
-
Notifications
You must be signed in to change notification settings - Fork 97
[WIP] Article revision feature #1299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[WIP] Article revision feature #1299
Conversation
@ckhackshaw is attempting to deploy a commit to the OceanBit Team on Vercel. A member of the Team first needs to authorize it. |
Fixes #1271 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We cannot use the existing Select
component, as it uses Preact and some other heavy libraries that we do not want in our blog post pages (too large of a bundle size).
Instead, we should use the new Popover API:
https://developer.mozilla.org/en-US/docs/Web/API/Popover_API
To build out a different select component without Preact.
You can find a similar demo here: https://mdn.github.io/dom-examples/popover-api/nested-popovers/ (View source) to see how it works
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Summarizing some details from our discussion :) Select popup component / behavior:
Getting the list of post versions:
|
@crutchcorn
This is a very basic WIP of the direction I am looking at with this feature.
As you can see, I am looking to make use of the Select component already in use in the project. Reason being, it has all the functionality that I need so make no sense reinventing the wheel.
I will just need to update the design, so I am thinking, an option to override the default styles but obviously keep default styles too.
I have one issue right now, the dropdown isn't working. I will investigate but feel free to lmk if there's anything that you see that sticks out to you that I haven't done/forgot which is causing/contributing to that issue. I haven't added any state or state setters as yet but I don't think that should affect the functionality.