-
-
Notifications
You must be signed in to change notification settings - Fork 97
[WIP] Use Hoof API for URL metadata #1335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
fennifith
wants to merge
10
commits into
main
Choose a base branch
from
hoof-metadata
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Merged
fennifith
added a commit
that referenced
this pull request
May 24, 2025
Fixes or removes a good handful of broken links found from testing #1335, as well as some redirects / domain changes. - `angular.io` moved to `angular.dev` - Tried to find the closest match to any angular docs/guides that had been moved - `gatsbyjs.org` moved to `gatsbyjs.com` - One link to `intro-to-web-accessability` (misspelt) in art-of-a11y-preface - A download link to some presentation slides (broken since the content refactor) in angular-templates-start-to-source - A number of deleted blog posts on external sites
7 tasks
fennifith
added a commit
that referenced
this pull request
Jun 20, 2025
Fixes #1233, but differently™ This PR changes the unified processor to return a "component tree" rather than a plain HTML string. This tree contains portions of raw HTML as well as props that would normally be passed to interactive components (tabs, file lists, code embeds, link previews, etc). The component tree is then passed to an Astro component, which is used recursively to render the raw HTML and components. This results in any imports (styles & scripts) being conditional on the component appearing in the post. It also means that scoped CSS and client hydration are supported. In the future, this component tree could be cached with the post content, and any SSR-dependent behavior could happen in the Astro components. ## Changes to note: - Components can now _only_ be nested at the root level of other components, or within specific elements that are transformed into components (`<details>`) This means that iframes can no longer be placed within a list, as was done in `example/index.md`. When this happens, the transformer will log & throw an error. - EPub generation is moved from a separate build script to a `pages/[slug].epub.ts` Astro route (this means it isn't parallelized, but takes advantage of caching & will massively improve the build time with #1335) - Conditional `tabs-small` behavior (keeping tabs at a fixed height) is removed ### TODO: - [x] Migrate tabs to preact - [x] Migrate in-content-ad to preact - [x] Migrate link-preview to preact - [x] Migrate filetree to preact - [x] Migrate IFramePlaceholder to preact - [x] Migrate hints to preact - [x] Validate epub changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This won't work until hoof is deployed.
This is part of #1231, and a prerequisite for migrating to Fly.io & enabling SSR.
openapi-typescript
andopenapi-fetch
(https://openapi-ts.dev/introduction)