Merge pull request #1740 from thecrypticace/fix/normalization-append-error

ai · web-flow · commit 8a1f6c2bcf25 · 2022-04-30T02:45:46.000+02:00
Fix `append()` failing after mutating nodes through .parent
diff --git a/lib/container.js b/lib/container.js
@@ -326,7 +326,7 @@ class Container extends Node {
           i.raws.before = sample.raws.before.replace(/\S/g, '')
         }
       }
-      i.parent = this
+      i.parent = this.proxyOf
       return i
     })
 
diff --git a/test/visitor.test.ts b/test/visitor.test.ts
@@ -7,6 +7,7 @@ import postcss, {
   Container,
   Root,
   Rule,
+  AtRule,
   Declaration,
   Plugin,
   PluginCreator,
@@ -1552,4 +1553,50 @@ test('marks cleaned nodes as dirty on moving in a document', () => {
   ])
 })
 
+test('append works after reassigning nodes through .parent', async () => {
+  let plugin: Plugin = {
+    postcssPlugin: 'test',
+
+    Rule(rule) {
+      if (
+        !(
+          rule.selector === '.nested' &&
+          rule.nodes.length === 1 &&
+          rule.nodes[0].type === 'atrule'
+        )
+      ) {
+        return
+      }
+
+      let atrule = rule.nodes[0]
+
+      atrule.append(rule.clone({ nodes: [] }).append(...atrule.nodes))
+
+      rule.after(atrule)
+      rule.remove()
+    },
+
+    OnceExit(root) {
+      let firstNode = root.nodes[0] as AtRule
+      let secondNode = root.nodes[1] as AtRule
+      let rule2 = secondNode.nodes[0]
+      rule2.parent!.nodes = rule2.parent!.nodes
+      firstNode.append(...secondNode.nodes)
+      secondNode.remove()
+    }
+  }
+
+  let { css } = await postcss([plugin]).process(
+    postcss.parse(
+      `@media (min-width: 640px) { .page { width: auto; } } .nested { @media (min-width: 640px) { width: auto; } }`
+    ),
+    { from: 'whatever' }
+  )
+
+  is(
+    css,
+    '@media (min-width: 640px) { .page { width: auto; } .nested { width: auto } }'
+  )
+})
+
 test.run()

Original file line number	Diff line number	Diff line change
`@@ -326,7 +326,7 @@ class Container extends Node {`
`326`	`326`	`i.raws.before = sample.raws.before.replace(/\S/g, '')`
`327`	`327`	`}`
`328`	`328`	`}`
`329`		`- i.parent = this`
	`329`	`+ i.parent = this.proxyOf`
`330`	`330`	`return i`
`331`	`331`	`})`
`332`	`332`