Skip to content

Commit 0fe77d7

Browse files
committed
The documentation for SELECT is incorrect in a sense: the syntax for a
join is defined as: from_item [ NATURAL ] join_type from_item [ ON join_condition | USING ( join_column_list ) ] However, if the join_type is an INNER or OUTER join, an ON, USING, or NATURAL clause *must* be specified (it's not optional, as that segment of the docs suggest). I'm not exactly sure what the best way to fix this is, so I've attached a patch adding a FIXME comment to the relevant section of the SGML. If anyone has any ideas on the proper way to outline join syntax, please speak up. Neil Conway <neilc@samurai.com> || PGP Key ID: DB3C29FC
1 parent e0d043b commit 0fe77d7

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

doc/src/sgml/ref/select.sgml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<!--
2-
$Header: /cvsroot/pgsql/doc/src/sgml/ref/select.sgml,v 1.64 2003/01/19 00:13:31 momjian Exp $
2+
$Header: /cvsroot/pgsql/doc/src/sgml/ref/select.sgml,v 1.65 2003/03/20 19:00:01 momjian Exp $
33
PostgreSQL documentation
44
-->
55

@@ -46,6 +46,11 @@ where <replaceable class="PARAMETER">from_item</replaceable> can be:
4646
<replaceable class="PARAMETER">table_function_name</replaceable> ( [ <replaceable class="parameter">argument</replaceable> [, ...] ] )
4747
AS ( <replaceable class="PARAMETER">column_definition_list</replaceable> )
4848
|
49+
<!--
50+
FIXME: this syntax is incorrect if the join type is an INNER or
51+
OUTER join (in which case one of NATURAL, ON ..., or USING ... is
52+
mandatory, not optional). What's the best way to fix this?
53+
-->
4954
<replaceable class="PARAMETER">from_item</replaceable> [ NATURAL ] <replaceable class="PARAMETER">join_type</replaceable> <replaceable class="PARAMETER">from_item</replaceable>
5055
[ ON <replaceable class="PARAMETER">join_condition</replaceable> | USING ( <replaceable class="PARAMETER">join_column_list</replaceable> ) ]
5156
</synopsis>

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy