pg_upgrade: Add missing newline in output, another one

petere · petere · commit 18d2d8ae42af · 2025-08-08T08:47:10.000+02:00
This came from the backport of commit f295494, but older branches require the explicit newline in messages (see commit 7652353).
diff --git a/src/bin/pg_upgrade/check.c b/src/bin/pg_upgrade/check.c
@@ -1282,7 +1282,7 @@ check_for_not_null_inheritance(ClusterInfo *cluster)
 		for (int i = 0; i < ntup; i++)
 		{
 			if (script == NULL && (script = fopen_priv(output_path, "w")) == NULL)
-				pg_fatal("could not open file \"%s\": %s", output_path, strerror(errno));
+				pg_fatal("could not open file \"%s\": %s\n", output_path, strerror(errno));
 			if (!db_used)
 			{
 				fprintf(script, "In database: %s\n", active_db->db_name);

Original file line number	Diff line number	Diff line change
`@@ -1282,7 +1282,7 @@ check_for_not_null_inheritance(ClusterInfo *cluster)`
`1282`	`1282`	`for (int i = 0; i < ntup; i++)`
`1283`	`1283`	`{`
`1284`	`1284`	`if (script == NULL && (script = fopen_priv(output_path, "w")) == NULL)`
`1285`		`- pg_fatal("could not open file \"%s\": %s", output_path, strerror(errno));`
	`1285`	`+ pg_fatal("could not open file \"%s\": %s\n", output_path, strerror(errno));`
`1286`	`1286`	`if (!db_used)`
`1287`	`1287`	`{`
`1288`	`1288`	`fprintf(script, "In database: %s\n", active_db->db_name);`