Skip to content

Commit 242e5af

Browse files
author
Etsuro Fujita
committed
Update obsolete comments in ResultRelInfo struct.
Commit c5b7ba4 changed things so that the ri_RootResultRelInfo field of this struct is set for both partitions and inheritance children and used for tuple routing and transition capture (before that commit, it was only set for partitions to route tuples into), but failed to update these comments. Author: Etsuro Fujita <etsuro.fujita@gmail.com> Reviewed-by: Dean Rasheed <dean.a.rasheed@gmail.com> Discussion: https://postgr.es/m/CAPmGK14NF5CcdCmTZpxrvpvBiT0y4EqKikW1r_wAu1CEHeOmUA%40mail.gmail.com Backpatch-through: 14
1 parent 82f9968 commit 242e5af

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

src/include/nodes/execnodes.h

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -528,16 +528,14 @@ typedef struct ResultRelInfo
528528
ExprState *ri_PartitionCheckExpr;
529529

530530
/*
531-
* Information needed by tuple routing target relations
531+
* Information needed by child result relations
532532
*
533-
* RootResultRelInfo gives the target relation mentioned in the query, if
534-
* it's a partitioned table. It is not set if the target relation
535-
* mentioned in the query is an inherited table, nor when tuple routing is
536-
* not needed.
533+
* ri_RootResultRelInfo gives the target relation mentioned in the query.
534+
* Used as the root for tuple routing and/or transition capture.
537535
*
538-
* RootToPartitionMap and PartitionTupleSlot, initialized by
539-
* ExecInitRoutingInfo, are non-NULL if partition has a different tuple
540-
* format than the root table.
536+
* ri_RootToPartitionMap and ri_PartitionTupleSlot, initialized by
537+
* ExecInitRoutingInfo, are non-NULL if the relation is a partition to
538+
* route tuples into and has a different tuple format than the root table.
541539
*/
542540
struct ResultRelInfo *ri_RootResultRelInfo;
543541
TupleConversionMap *ri_RootToPartitionMap;

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy