Repair AlterTableOwner --- was failing for relations with indexes.

tglsfdc · tglsfdc · commit 507ed0332abf · 2002-06-17T14:31:32.000Z
diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/commands/tablecmds.c,v 1.16 2002/05/21 22:05:54 tgl Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/commands/tablecmds.c,v 1.17 2002/06/17 14:31:32 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -2747,7 +2747,8 @@ AlterTableOwner(Oid relationOid, int32 newOwnerSysId)
 	Form_pg_class	tuple_class;
 
 	/* Get exclusive lock till end of transaction on the target table */
-	target_rel = heap_open(relationOid, AccessExclusiveLock);
+	/* Use relation_open here so that we work on indexes... */
+	target_rel = relation_open(relationOid, AccessExclusiveLock);
 
 	/* Get its pg_class tuple, too */
 	class_rel = heap_openr(RelationRelationName, RowExclusiveLock);
@@ -2807,7 +2808,7 @@ AlterTableOwner(Oid relationOid, int32 newOwnerSysId)
 
 	heap_freetuple(tuple);
 	heap_close(class_rel, RowExclusiveLock);
-	heap_close(target_rel, NoLock);
+	relation_close(target_rel, NoLock);
 }
 
 static void

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $Header: /cvsroot/pgsql/src/backend/commands/tablecmds.c,v 1.16 2002/05/21 22:05:54 tgl Exp $`
	`11`	`+ * $Header: /cvsroot/pgsql/src/backend/commands/tablecmds.c,v 1.17 2002/06/17 14:31:32 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -2747,7 +2747,8 @@ AlterTableOwner(Oid relationOid, int32 newOwnerSysId)`
`2747`	`2747`	`Form_pg_class tuple_class;`
`2748`	`2748`
`2749`	`2749`	`/* Get exclusive lock till end of transaction on the target table */`
`2750`		`- target_rel = heap_open(relationOid, AccessExclusiveLock);`
	`2750`	`+ /* Use relation_open here so that we work on indexes... */`
	`2751`	`+ target_rel = relation_open(relationOid, AccessExclusiveLock);`
`2751`	`2752`
`2752`	`2753`	`/* Get its pg_class tuple, too */`
`2753`	`2754`	`class_rel = heap_openr(RelationRelationName, RowExclusiveLock);`
`@@ -2807,7 +2808,7 @@ AlterTableOwner(Oid relationOid, int32 newOwnerSysId)`
`2807`	`2808`
`2808`	`2809`	`heap_freetuple(tuple);`
`2809`	`2810`	`heap_close(class_rel, RowExclusiveLock);`
`2810`		`- heap_close(target_rel, NoLock);`
	`2811`	`+ relation_close(target_rel, NoLock);`
`2811`	`2812`	`}`
`2812`	`2813`
`2813`	`2814`	`static void`