Fix spurious warning after vacuuming a page on a table with no indexes.

hlinnaka · hlinnaka · commit 5fdab1ea516e · 2013-09-26T11:39:56.000+03:00
There is a rare race condition, when a transaction that inserted a tuple
aborts while vacuum is processing the page containing the inserted tuple.
Vacuum prunes the page first, which normally removes any dead tuples, but
if the inserting transaction aborts right after that, the loop after
pruning will see a dead tuple and remove it instead. That's OK, but if the
page is on a table with no indexes, and the page becomes completely empty
after removing the dead tuple (or tuples) on it, it will be immediately
marked as all-visible. That's OK, but the sanity check in vacuum would
throw a warning because it thinks that the page contains dead tuples and
was nevertheless marked as all-visible, even though it just vacuumed away
the dead tuples and so it doesn't actually contain any.

Spotted this while reading the code. It's difficult to hit the race
condition otherwise, but can be done by putting a breakpoint after the
heap_page_prune() call.

Backpatch all the way to 8.4, where this code first appeared.
diff --git a/src/backend/commands/vacuumlazy.c b/src/backend/commands/vacuumlazy.c
@@ -720,6 +720,8 @@ lazy_scan_heap(Relation onerel, LVRelStats *vacrelstats,
 		{
 			/* Remove tuples from heap */
 			lazy_vacuum_page(onerel, blkno, buf, 0, vacrelstats);
+			has_dead_tuples = false;
+
 			/* Forget the now-vacuumed tuples, and press on */
 			vacrelstats->num_dead_tuples = 0;
 			vacuumed_pages++;

Original file line number	Diff line number	Diff line change
`@@ -720,6 +720,8 @@ lazy_scan_heap(Relation onerel, LVRelStats *vacrelstats,`
`720`	`720`	`{`
`721`	`721`	`/* Remove tuples from heap */`
`722`	`722`	`lazy_vacuum_page(onerel, blkno, buf, 0, vacrelstats);`
	`723`	`+ has_dead_tuples = false;`
	`724`	`+`
`723`	`725`	`/* Forget the now-vacuumed tuples, and press on */`
`724`	`726`	`vacrelstats->num_dead_tuples = 0;`
`725`	`727`	`vacuumed_pages++;`