Fix compilation warning with SerializeClientConnectionInfo()

michaelpq · michaelpq · commit 6304256e79c7 · 2025-08-14T16:21:50.000+09:00
This function uses an argument named "maxsize" that is only used in assertions, being set once outside the assertion area. Recent gcc versions with -Wunused-but-set-parameter complain about a warning when building without assertions enabled, because of that. In order to fix this issue, PG_USED_FOR_ASSERTS_ONLY is added to the function argument of SerializeClientConnectionInfo(), which is the first time we are doing so in the tree. The CI is fine with the change, but let's see what the buildfarm has to say on the matter. Reviewed-by: Andres Freund <andres@anarazel.de> Reviewed-by: Jacob Champion <jchampion@postgresql.org> Discussion: https://postgr.es/m/pevajesswhxafjkivoq3yvwxga77tbncghlf3gq5fvchsvfuda@6uivg25sb3nx Backpatch-through: 16
diff --git a/src/backend/utils/init/miscinit.c b/src/backend/utils/init/miscinit.c
@@ -1099,7 +1099,8 @@ EstimateClientConnectionInfoSpace(void)
  * Serialize MyClientConnectionInfo for use by parallel workers.
  */
 void
-SerializeClientConnectionInfo(Size maxsize, char *start_address)
+SerializeClientConnectionInfo(Size maxsize PG_USED_FOR_ASSERTS_ONLY,
+							  char *start_address)
 {
 	SerializedClientConnectionInfo serialized = {0};
 

Original file line number	Diff line number	Diff line change
`@@ -1099,7 +1099,8 @@ EstimateClientConnectionInfoSpace(void)`
`1099`	`1099`	`* Serialize MyClientConnectionInfo for use by parallel workers.`
`1100`	`1100`	`*/`
`1101`	`1101`	`void`
`1102`		`-SerializeClientConnectionInfo(Size maxsize, char *start_address)`
	`1102`	`+SerializeClientConnectionInfo(Size maxsize PG_USED_FOR_ASSERTS_ONLY,`
	`1103`	`+ char *start_address)`
`1103`	`1104`	`{`
`1104`	`1105`	`SerializedClientConnectionInfo serialized = {0};`
`1105`	`1106`