Fix handling of OID wraparound while in standalone mode.

tglsfdc · tglsfdc · commit 65d2b4be0c86 · 2013-05-13T15:41:21.000-04:00
If OID wraparound should occur while in standalone mode (unlikely but
possible), we want to advance the counter to FirstNormalObjectId not
FirstBootstrapObjectId.  Otherwise, user objects might be created with OIDs
in the system-reserved range.  That isn't immediately harmful but it poses
a risk of conflicts during future pg_upgrade operations.

Noted by Andres Freund.  Back-patch to all supported branches, since all of
them are supported sources for pg_upgrade operations.
diff --git a/src/backend/access/transam/varsup.c b/src/backend/access/transam/varsup.c
@@ -333,18 +333,18 @@ GetNewObjectId(void)
 	 * iterations in GetNewOid.)  Note we are relying on unsigned comparison.
 	 *
 	 * During initdb, we start the OID generator at FirstBootstrapObjectId, so
-	 * we only enforce wrapping to that point when in bootstrap or standalone
-	 * mode.  The first time through this routine after normal postmaster
-	 * start, the counter will be forced up to FirstNormalObjectId. This
-	 * mechanism leaves the OIDs between FirstBootstrapObjectId and
-	 * FirstNormalObjectId available for automatic assignment during initdb,
-	 * while ensuring they will never conflict with user-assigned OIDs.
+	 * we only wrap if before that point when in bootstrap or standalone mode.
+	 * The first time through this routine after normal postmaster start, the
+	 * counter will be forced up to FirstNormalObjectId.  This mechanism
+	 * leaves the OIDs between FirstBootstrapObjectId and FirstNormalObjectId
+	 * available for automatic assignment during initdb, while ensuring they
+	 * will never conflict with user-assigned OIDs.
 	 */
 	if (ShmemVariableCache->nextOid < ((Oid) FirstNormalObjectId))
 	{
 		if (IsPostmasterEnvironment)
 		{
-			/* wraparound in normal environment */
+			/* wraparound, or first post-initdb assignment, in normal mode */
 			ShmemVariableCache->nextOid = FirstNormalObjectId;
 			ShmemVariableCache->oidCount = 0;
 		}
@@ -353,8 +353,8 @@ GetNewObjectId(void)
 			/* we may be bootstrapping, so don't enforce the full range */
 			if (ShmemVariableCache->nextOid < ((Oid) FirstBootstrapObjectId))
 			{
-				/* wraparound in standalone environment? */
-				ShmemVariableCache->nextOid = FirstBootstrapObjectId;
+				/* wraparound in standalone mode (unlikely but possible) */
+				ShmemVariableCache->nextOid = FirstNormalObjectId;
 				ShmemVariableCache->oidCount = 0;
 			}
 		}

Original file line number	Diff line number	Diff line change
`@@ -333,18 +333,18 @@ GetNewObjectId(void)`
`333`	`333`	`* iterations in GetNewOid.) Note we are relying on unsigned comparison.`
`334`	`334`	`*`
`335`	`335`	`* During initdb, we start the OID generator at FirstBootstrapObjectId, so`
`336`		`- * we only enforce wrapping to that point when in bootstrap or standalone`
`337`		`- * mode. The first time through this routine after normal postmaster`
`338`		`- * start, the counter will be forced up to FirstNormalObjectId. This`
`339`		`- * mechanism leaves the OIDs between FirstBootstrapObjectId and`
`340`		`- * FirstNormalObjectId available for automatic assignment during initdb,`
`341`		`- * while ensuring they will never conflict with user-assigned OIDs.`
	`336`	`+ * we only wrap if before that point when in bootstrap or standalone mode.`
	`337`	`+ * The first time through this routine after normal postmaster start, the`
	`338`	`+ * counter will be forced up to FirstNormalObjectId. This mechanism`
	`339`	`+ * leaves the OIDs between FirstBootstrapObjectId and FirstNormalObjectId`
	`340`	`+ * available for automatic assignment during initdb, while ensuring they`
	`341`	`+ * will never conflict with user-assigned OIDs.`
`342`	`342`	`*/`
`343`	`343`	`if (ShmemVariableCache->nextOid < ((Oid) FirstNormalObjectId))`
`344`	`344`	`{`
`345`	`345`	`if (IsPostmasterEnvironment)`
`346`	`346`	`{`
`347`		`- /* wraparound in normal environment */`
	`347`	`+ /* wraparound, or first post-initdb assignment, in normal mode */`
`348`	`348`	`ShmemVariableCache->nextOid = FirstNormalObjectId;`
`349`	`349`	`ShmemVariableCache->oidCount = 0;`
`350`	`350`	`}`
`@@ -353,8 +353,8 @@ GetNewObjectId(void)`
`353`	`353`	`/* we may be bootstrapping, so don't enforce the full range */`
`354`	`354`	`if (ShmemVariableCache->nextOid < ((Oid) FirstBootstrapObjectId))`
`355`	`355`	`{`
`356`		`- /* wraparound in standalone environment? */`
`357`		`- ShmemVariableCache->nextOid = FirstBootstrapObjectId;`
	`356`	`+ /* wraparound in standalone mode (unlikely but possible) */`
	`357`	`+ ShmemVariableCache->nextOid = FirstNormalObjectId;`
`358`	`358`	`ShmemVariableCache->oidCount = 0;`
`359`	`359`	`}`
`360`	`360`	`}`