Fix connection leak in dblink when dblink_connect() or dblink_connect_u()

ItGacky · ItGacky · commit 71dca6e00075 · 2010-06-09T01:00:50.000Z
end with "duplicate connection name" errors.

Backported to release 7.4.
diff --git a/contrib/dblink/dblink.c b/contrib/dblink/dblink.c
@@ -1980,9 +1980,14 @@ createNewConnection(const char *name, remoteConn * con)
 				 errmsg("out of memory")));
 
 	if (found)
+	{
+		PQfinish(rconn->conn);
+		pfree(rconn);
+
 		ereport(ERROR,
 				(errcode(ERRCODE_DUPLICATE_OBJECT),
 				 errmsg("duplicate connection name")));
+	}
 
 	hentry->rcon = con;
 	strncpy(hentry->name, name, NAMEDATALEN - 1);
