Prevent creating window functions with default arguments.

tglsfdc · tglsfdc · commit 72c8a584bf7d · 2013-11-06T13:32:36.000-05:00
Insertion of default arguments doesn't work for window functions, which is
likely to cause a crash at runtime if the implementation code doesn't check
the number of actual arguments carefully.  It doesn't seem worth working
harder than this for pre-9.2 branches.
diff --git a/src/backend/catalog/pg_proc.c b/src/backend/catalog/pg_proc.c
@@ -283,6 +283,12 @@ ProcedureCreate(const char *procedureName,
 		}
 	}
 
+	/* Guard against a case the planner doesn't handle yet */
+	if (isWindowFunc && parameterDefaults != NIL)
+		ereport(ERROR,
+				(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
+				 errmsg("window functions cannot have default arguments")));
+
 	/*
 	 * All seems OK; prepare the data to be inserted into pg_proc.
 	 */

Original file line number	Diff line number	Diff line change
`@@ -283,6 +283,12 @@ ProcedureCreate(const char *procedureName,`
`283`	`283`	`}`
`284`	`284`	`}`
`285`	`285`
	`286`	`+ /* Guard against a case the planner doesn't handle yet */`
	`287`	`+ if (isWindowFunc && parameterDefaults != NIL)`
	`288`	`+ ereport(ERROR,`
	`289`	`+ (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),`
	`290`	`+ errmsg("window functions cannot have default arguments")));`
	`291`	`+`
`286`	`292`	`/*`
`287`	`293`	`* All seems OK; prepare the data to be inserted into pg_proc.`
`288`	`294`	`*/`