Revert unnecessary check for NULL

hlinnaka · hlinnaka · commit 807ee417e562 · 2025-08-22T14:47:19.000+03:00
Jelte pointed out that this was unnecessary, but I failed to remove it before pushing f6f0542. Oops. Reviewed-by: Jelte Fennema-Nio <postgres@jeltef.nl> Discussion: https://www.postgresql.org/message-id/CAGECzQT%3DxNV-V%2BvFC7YQwYQMj0wGN61b3p%3DJ1_rL6M0vbjTtrA@mail.gmail.com Backpatch-through: 18
diff --git a/src/interfaces/libpq/fe-protocol3.c b/src/interfaces/libpq/fe-protocol3.c
@@ -1645,8 +1645,7 @@ getNotify(PGconn *conn)
 	}
 	if (pqGets(&conn->workBuffer, conn))
 	{
-		if (svname)
-			free(svname);
+		free(svname);
 		return EOF;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -1645,8 +1645,7 @@ getNotify(PGconn *conn)`
`1645`	`1645`	`}`
`1646`	`1646`	`if (pqGets(&conn->workBuffer, conn))`
`1647`	`1647`	`{`
`1648`		`- if (svname)`
`1649`		`- free(svname);`
	`1648`	`+ free(svname);`
`1650`	`1649`	`return EOF;`
`1651`	`1650`	`}`
`1652`	`1651`