Remove unnecessary pg_verifymbstr() calls from tsvector/query in functions.

hlinnaka · hlinnaka · commit f15c2eae9c2f · 2012-05-14T14:30:32.000+03:00
The input should've been validated well before it hits the input function.
Doing so again is a waste of cycles.
diff --git a/src/backend/utils/adt/tsquery.c b/src/backend/utils/adt/tsquery.c
@@ -570,8 +570,6 @@ tsqueryin(PG_FUNCTION_ARGS)
 {
 	char	   *in = PG_GETARG_CSTRING(0);
 
-	pg_verifymbstr(in, strlen(in), false);
-
 	PG_RETURN_TSQUERY(parse_tsquery(in, pushval_asis, PointerGetDatum(NULL), false));
 }
 
diff --git a/src/backend/utils/adt/tsvector.c b/src/backend/utils/adt/tsvector.c
@@ -198,8 +198,6 @@ tsvectorin(PG_FUNCTION_ARGS)
 	char	   *cur;
 	int			buflen = 256;	/* allocated size of tmpbuf */
 
-	pg_verifymbstr(buf, strlen(buf), false);
-
 	state = init_tsvector_parser(buf, false, false);
 
 	arrlen = 64;

Original file line number	Diff line number	Diff line change
`@@ -570,8 +570,6 @@ tsqueryin(PG_FUNCTION_ARGS)`
`570`	`570`	`{`
`571`	`571`	`char *in = PG_GETARG_CSTRING(0);`
`572`	`572`
`573`		`- pg_verifymbstr(in, strlen(in), false);`
`574`		`-`
`575`	`573`	`PG_RETURN_TSQUERY(parse_tsquery(in, pushval_asis, PointerGetDatum(NULL), false));`
`576`	`574`	`}`
`577`	`575`