-
Notifications
You must be signed in to change notification settings - Fork 318
Defects of deploy mechanism #1259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We handle that hypothetical case. Rollback is restricted to models other than the currently deployed one. https://github.com/postgresml/postgresml/blob/master/pgml-extension/src/api.rs#L356-L362 Feel free to re-open if I've missed what you're getting at, or you have a test case that illustrates misbehavior. The code you've listed runs for me. |
So is the description of rollback in pgml's official documentation not updated or not comprehensive enough? |
Our docs are also open source, so you can contribute something that makes the behavior more clear.
|
If I could use model.id for deployment, then the bugs in my hypothetical testing strategy would be solved. I will clearly explain my hypothesis here, subject to several conditions:
Based on the above 4 conditions.
Now, we can say that this project cannot be used and has to be deleted, because we can only deploy a fourth model that cannot be predicted thanks lot for your reply! |
Uh oh!
There was an error while loading. Please reload this page.
Defects of the deployment mechanism. I trained four times and did not deploy automatically.
Assume that my fourth model has the highest score, but its predict cannot be used.
At this time, I use deploy to deploy. There are three ways to deploy, most_recent, best_score, and rollback. most_recent will deploy the fourth model, best_score will also deploy the fourth model, and rollback will not work. So this project is an invalid project, right?
I can only delete my project, there is no other way.
-- just change xgboost 、xgboost_random_forest 、lightgbm、catboost
select from pgml.train(
project_name => 'Diabetes Regression',
task => 'regression',
relation_name => 'pgml.diabetes',
y_column_name => 'target',
algorithm=> 'ada_boost'
);
SELECT from pgml.deploy(
project_name => 'Diabetes Regression',
strategy => 'best_score'
);
The text was updated successfully, but these errors were encountered: