Some improvements to static analyzer checking.

Alexander Korotkov · Alexander Korotkov · commit 9902ebc833fa · 2018-02-16T00:41:52.000+03:00
diff --git a/Makefile b/Makefile
@@ -26,6 +26,10 @@ include $(top_builddir)/src/Makefile.global
 include $(top_srcdir)/contrib/contrib-global.mk
 endif
 
+ifdef USE_ASSERT_CHECKING
+override CFLAGS += -DUSE_ASSERT_CHECKING
+endif
+
 jsquery_gram.o: jsquery_scan.c
 
 jsquery_gram.c: BISONFLAGS += -d
diff --git a/jsonb_gin_ops.c b/jsonb_gin_ops.c
@@ -462,7 +462,7 @@ make_value_path_entry_handler(ExtractedNode *node, Pointer extra)
 {
 	Entries	   *e = (Entries *)extra;
 	uint32		hash;
-	bool		lossy, partialMatch;
+	bool		lossy, partialMatch = false;
 	GINKey	   *key;
 	KeyExtra   *keyExtra;
 	int			result;
@@ -1175,6 +1175,7 @@ gin_debug_query_path_value(PG_FUNCTION_ARGS)
 	Entries		e = {0};
 	char	   *s;
 
+
 	jq = PG_GETARG_JSQUERY(0);
 	s = debugJsQuery(jq, make_path_value_entry_handler,
 										check_path_value_entry_handler, (Pointer)&e);
diff --git a/jsquery_op.c b/jsquery_op.c
@@ -270,7 +270,7 @@ checkScalarIn(JsQueryItem *jsq, JsonbValue *jb)
 static bool
 executeArrayOp(JsQueryItem *jsq, int32 op, JsonbValue *jb)
 {
-	int32			r;
+	int32			r = 0; /* keep static analyzer quiet */
 	JsonbIterator	*it;
 	JsonbValue		v;
 	JsQueryItem	elem;
diff --git a/travis/pg-travis-test.sh b/travis/pg-travis-test.sh
@@ -36,7 +36,7 @@ if [ $CHECK_CODE = "true" ]; then
 	if [ "$CC" = "clang" ]; then
 		sudo apt-get -y install -qq clang-$LLVM_VER
 
-		scan-build-$LLVM_VER --status-bugs make USE_PGXS=1 PG_CONFIG=$config_path || status=$?
+		scan-build-$LLVM_VER --status-bugs make USE_PGXS=1 USE_ASSERT_CHECKING=1 PG_CONFIG=$config_path || status=$?
 		exit $status
 
 	elif [ "$CC" = "gcc" ]; then

Original file line number	Diff line number	Diff line change
`@@ -270,7 +270,7 @@ checkScalarIn(JsQueryItem jsq, JsonbValue jb)`
`270`	`270`	`static bool`
`271`	`271`	`executeArrayOp(JsQueryItem jsq, int32 op, JsonbValue jb)`
`272`	`272`	`{`
`273`		`- int32 r;`
	`273`	`+ int32 r = 0; /* keep static analyzer quiet */`
`274`	`274`	`JsonbIterator *it;`
`275`	`275`	`JsonbValue v;`
`276`	`276`	`JsQueryItem elem;`