Make code of stamp_arithm's ExtractStr more readable and sensible

nataraj-hates-MS-for-stealing-github · nataraj-hates-MS-for-stealing-github · commit e42555e87bfb · 2023-01-19T12:34:18.000+03:00
diff --git a/blobstamper/stamp_arithm.h b/blobstamper/stamp_arithm.h
@@ -1,6 +1,6 @@
 /******************************************************************************
  *
- * Copyright 2021 Nikolay Shaplov (Postgres Professional)
+ * Copyright 2021-2023 Nikolay Shaplov (Postgres Professional)
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -34,15 +34,8 @@ template<class T> class StampArithm: public StampFixed, public StampBaseStr, pub
 template<class T> std::string
 StampArithm<T>::ExtractStr(Blob &blob)
 {
-    std::string res;
-    std::vector<char> v = this->ExtractBin(blob);
-
-    if (v.size() == 0)
-        return "";
-
-    T *pT = (T *) &v[0];
-
-    return to_string_precise(*pT);
+    T value = this->ExtractValue(blob);
+    return to_string_precise(value);
 }
 
 template<class T> T

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`/******************************************************************************`
`2`	`2`	`*`
`3`		`- * Copyright 2021 Nikolay Shaplov (Postgres Professional)`
	`3`	`+ * Copyright 2021-2023 Nikolay Shaplov (Postgres Professional)`
`4`	`4`	`*`
`5`	`5`	`* Licensed under the Apache License, Version 2.0 (the "License");`
`6`	`6`	`* you may not use this file except in compliance with the License.`
`@@ -34,15 +34,8 @@ template<class T> class StampArithm: public StampFixed, public StampBaseStr, pub`
`34`	`34`	`template<class T> std::string`
`35`	`35`	`StampArithm<T>::ExtractStr(Blob &blob)`
`36`	`36`	`{`
`37`		`- std::string res;`
`38`		`- std::vector<char> v = this->ExtractBin(blob);`
`39`		`-`
`40`		`- if (v.size() == 0)`
`41`		`- return "";`
`42`		`-`
`43`		`- T pT = (T ) &v[0];`
`44`		`-`
`45`		`- return to_string_precise(*pT);`
	`37`	`+ T value = this->ExtractValue(blob);`
	`38`	`+ return to_string_precise(value);`
`46`	`39`	`}`
`47`	`40`
`48`	`41`	`template<class T> T`