Fix lifetime of mtm_log_gucs desc string.

arssher · arssher · commit 1ced4ac3967e · 2021-03-18T16:06:48.000+03:00
I checked that full_name is copied, but didn't pay attention that desc isn't,
which is strange.
diff --git a/src/multimaster.c b/src/multimaster.c
@@ -691,13 +691,14 @@ NULL);
 	for (i = 0; mtm_log_gucs[i].name; i++)
 	{
 		MtmLogGuc *guc = &mtm_log_gucs[i];
-		char full_name[128];
-		char desc[128];
-
-		snprintf(full_name, sizeof(full_name),
-				 "multimaster.%s_log_level", guc->name);
-		snprintf(desc, sizeof(desc),
-				 "log level for %s multimaster messages", guc->name);
+		char *full_name;
+		char *desc;
+		MemoryContext oldcontext;
+
+		oldcontext = MemoryContextSwitchTo(TopMemoryContext);
+		full_name = psprintf("multimaster.%s_log_level", guc->name);
+		desc = psprintf("log level for %s multimaster messages", guc->name);
+		MemoryContextSwitchTo(oldcontext);
 		DefineCustomEnumVariable(
 			full_name,
 			desc,
