Merge pull request #13 from postgrespro/ee13-5359

funny-falcon · web-flow · commit 616051905b8f · 2021-08-23T21:38:38.000+03:00
Bugfix. Multimaster mustn't send the T_CallStmt utility statement to …
diff --git a/expected/multimaster.out b/expected/multimaster.out
@@ -488,3 +488,45 @@ table seq_test;
  105
 (8 rows)
 
+--
+-- Check a sequence generation by function, procedure, direct insertion.
+--
+CREATE SEQUENCE seq1;
+CREATE TABLE t1 (id int);
+CREATE OR REPLACE PROCEDURE p1 () LANGUAGE 'plpgsql' AS $$
+BEGIN
+	INSERT INTO t1 (id) VALUES (nextval('seq1'::regclass));
+END; $$;
+CREATE OR REPLACE FUNCTION p2 () RETURNS VOID LANGUAGE 'plpgsql' AS $$
+BEGIN
+	INSERT INTO t1 (id) VALUES (nextval('seq1'::regclass));
+END; $$;
+-- Generate value by different ways.
+CALL p1();
+SELECT p2();
+ p2 
+----
+ 
+(1 row)
+
+INSERT INTO t1 (id) VALUES (nextval('seq1'::regclass));
+-- Fix generated values of a sequence
+SELECT * FROM t1 ORDER BY id;
+ id 
+----
+  1
+  4
+  7
+(3 rows)
+
+-- Try to UPDATE. In the case of data divergence we will get an error.
+UPDATE t1 SET id = id + 1;
+-- Check for new values, just to be sure.
+SELECT * FROM t1  ORDER BY id;
+ id 
+----
+  2
+  5
+  8
+(3 rows)
+
diff --git a/sql/multimaster.sql b/sql/multimaster.sql
@@ -327,3 +327,32 @@ insert into seq_test values (default);
 insert into seq_test values (default);
 \c :node1
 table seq_test;
+
+--
+-- Check a sequence generation by function, procedure, direct insertion.
+--
+CREATE SEQUENCE seq1;
+CREATE TABLE t1 (id int);
+CREATE OR REPLACE PROCEDURE p1 () LANGUAGE 'plpgsql' AS $$
+BEGIN
+	INSERT INTO t1 (id) VALUES (nextval('seq1'::regclass));
+END; $$;
+
+CREATE OR REPLACE FUNCTION p2 () RETURNS VOID LANGUAGE 'plpgsql' AS $$
+BEGIN
+	INSERT INTO t1 (id) VALUES (nextval('seq1'::regclass));
+END; $$;
+
+-- Generate value by different ways.
+CALL p1();
+SELECT p2();
+INSERT INTO t1 (id) VALUES (nextval('seq1'::regclass));
+
+-- Fix generated values of a sequence
+SELECT * FROM t1 ORDER BY id;
+
+-- Try to UPDATE. In the case of data divergence we will get an error.
+UPDATE t1 SET id = id + 1;
+
+-- Check for new values, just to be sure.
+SELECT * FROM t1  ORDER BY id;
diff --git a/src/ddl.c b/src/ddl.c
@@ -947,6 +947,7 @@ MtmProcessUtilitySender(PlannedStmt *pstmt, const char *queryString,
 		case T_PlannedStmt:
 		case T_FetchStmt:
 		case T_DoStmt:
+		case T_CallStmt:
 		case T_CommentStmt:
 		case T_PrepareStmt:
 		case T_ExecuteStmt:
