Improve sability of 008_bugfixes.pl test.

ololobus · ololobus · commit e393be8a1ed8 · 2021-04-15T13:38:49.000+03:00
Also make free port choosing routine work on BSD-like systems (e.g.
macOS).
diff --git a/Cluster.pm b/Cluster.pm
@@ -32,7 +32,7 @@ sub mm_get_free_port
 	{
 
 		# advance $port, wrapping correctly around range end
-		$port = 26000 if ++$port == 27000;
+		$port = 26000 if ++$port >= 27000;
 		print "# Checking port $port\n";
 
 		# Check first that candidate port number is not included in
@@ -58,7 +58,7 @@ sub mm_get_free_port
 		if ($found == 1)
 		{
 			foreach my $addr (qw(127.0.0.1),
-				$PostgresNode::use_tcp ? qw(127.0.0.2 127.0.0.3 0.0.0.0) : ())
+				$PostgresNode::use_tcp && ($^O eq "linux" || $windows_os) ? qw(127.0.0.2 127.0.0.3 0.0.0.0) : ())
 			{
 				if (!PostgresNode::can_bind($addr, $port))
 				{
diff --git a/t/008_bugfixes.pl b/t/008_bugfixes.pl
@@ -1,10 +1,15 @@
+use Carp;
+use POSIX;
 use strict;
+use Test::More;
+use TestLib;
+use Time::HiRes qw(usleep);
 use warnings;
-use Carp;
+
 use PostgresNode;
 use Cluster;
-use TestLib;
-use Test::More;
+
+use Test::More tests => Cluster::is_ee() ? 6 : 5;
 
 my $cluster = new Cluster(3);
 $cluster->init();
@@ -42,7 +47,7 @@
 	$hash2 = $cluster->safe_psql(2, $hash_query);
 	note("$hash0, $hash1, $hash2");
 	is( (($hash0 eq $hash1) and ($hash1 eq $hash2)) , 1,
-    "Check that hash is the same after query");
+		"Check that hash is the same after query");
 }
 
 $cluster->safe_psql(0, q{
@@ -72,7 +77,7 @@
 $hash2 = $cluster->safe_psql(2, $hash_query);
 note("$hash0, $hash1, $hash2");
 is( (($hash0 eq $hash1) and ($hash1 eq $hash2)) , 1,
-    "Check that hash is the same after query");
+	"Check that hash is the same after query");
 
 # ##############################################################################
 #
@@ -93,30 +98,35 @@
 
 # Simulate payload
 $cluster->pgbench(0, ('-i', '-n', -s => '1') );
-my $pgb1 = $cluster->pgbench_async(0, ('-n', -T => '15', -j=>'5', -c => '5') );
-sleep(5);
+note( strftime('%Y-%m-%d %H:%M:%S', localtime) . ": starting async pgbench" );
+my $pgb1 = $cluster->pgbench_async(0, ('-n', -T => '25', -j => '1', -c => '5') );
 
 my $pid0;
 my $attempts     = 0;
+
+note( strftime('%Y-%m-%d %H:%M:%S', localtime) . ": starting polling of backend pid" );
 while (1)
 {
 	$pid0 = $cluster->safe_psql(0, "SELECT pid FROM pg_stat_activity
 								WHERE	backend_type LIKE 'client backend'
 								AND query LIKE 'UPDATE%' LIMIT 1;");
 
 	# bf says we might be really unlucky to find no backend doing update
-	if ($pid0 ne "")
+	# It does not make much sense to try longer than pgbench run lasts,
+	# since we need an active backend to kill.  So let it be 25 seconds
+	# both for pgbench_async() and this pg_stat_activity polling.
+	if ( ($pid0 ne "") || $attempts >= 25*10 )
 	{
 		last;
 	}
+
 	# Wait 0.1 second before retrying.
 	usleep(100_000);
 	$attempts++;
-	if ($attempts >= 180*10)
-	{
-		croak 'failed to fetch backend pid';
-	}
 }
+note( strftime('%Y-%m-%d %H:%M:%S', localtime) . ": finished polling of backend pid" );
+is( ($pid0 ne ""), 1,
+	"found an active backend doing UPDATE" );
 
 # Simulate hard crash
 note("Simulate hard crash of a backend by SIGKILL to $pid0");

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ sub mm_get_free_port`
`32`	`32`	`{`
`33`	`33`
`34`	`34`	`# advance $port, wrapping correctly around range end`
`35`		`- $port = 26000 if ++$port == 27000;`
	`35`	`+ $port = 26000 if ++$port >= 27000;`
`36`	`36`	`print "# Checking port $port\n";`
`37`	`37`
`38`	`38`	`# Check first that candidate port number is not included in`
`@@ -58,7 +58,7 @@ sub mm_get_free_port`
`58`	`58`	`if ($found == 1)`
`59`	`59`	`{`
`60`	`60`	`foreach my $addr (qw(127.0.0.1),`
`61`		`- $PostgresNode::use_tcp ? qw(127.0.0.2 127.0.0.3 0.0.0.0) : ())`
	`61`	`+ $PostgresNode::use_tcp && ($^O eq "linux" \|\| $windows_os) ? qw(127.0.0.2 127.0.0.3 0.0.0.0) : ())`
`62`	`62`	`{`
`63`	`63`	`if (!PostgresNode::can_bind($addr, $port))`
`64`	`64`	`{`