[PGPRO-5255] fix that ALTER TABLE IF EXISTS ... RENAME TO of not existed table generate ERROR instead of NOTICE

kulaginm · kulaginm · commit 2062ab9538b9 · 2021-06-28T15:21:49.000+03:00
diff --git a/expected/pathman_utility_stmt.out b/expected/pathman_utility_stmt.out
@@ -370,4 +370,11 @@ SELECT create_hash_partitions('drop_index.test', 'val', 2);
 DROP INDEX CONCURRENTLY drop_index.test_0_val_idx;
 DROP SCHEMA drop_index CASCADE;
 NOTICE:  drop cascades to 3 other objects
+/*
+ * Test, that ALTER TABLE IF EXISTS ... RENAME TO of not existed table generate NOTICE instead of ERROR
+ */
+CREATE SCHEMA rename_nonexistent;
+ALTER TABLE IF EXISTS rename_nonexistent.nonexistent_table RENAME TO other_table_name;
+NOTICE:  relation "nonexistent_table" does not exist, skipping
+DROP SCHEMA rename_nonexistent CASCADE;
 DROP EXTENSION pg_pathman;
diff --git a/sql/pathman_utility_stmt.sql b/sql/pathman_utility_stmt.sql
@@ -250,6 +250,12 @@ DROP INDEX CONCURRENTLY drop_index.test_0_val_idx;
 
 DROP SCHEMA drop_index CASCADE;
 
+/*
+ * Test, that ALTER TABLE IF EXISTS ... RENAME TO of not existed table generate NOTICE instead of ERROR
+ */
+CREATE SCHEMA rename_nonexistent;
+ALTER TABLE IF EXISTS rename_nonexistent.nonexistent_table RENAME TO other_table_name;
+DROP SCHEMA rename_nonexistent CASCADE;
 
 
 DROP EXTENSION pg_pathman;
diff --git a/src/utility_stmt_hooking.c b/src/utility_stmt_hooking.c
@@ -175,7 +175,10 @@ is_pathman_related_table_rename(Node *parsetree,
 	/* Fetch Oid of this relation */
 	relation_oid = RangeVarGetRelid(rename_stmt->relation,
 									AccessShareLock,
-									false);
+									rename_stmt->missing_ok);
+	/* PGPRO-5255: check ALTER TABLE IF EXISTS of non existent table */
+	if (rename_stmt->missing_ok && relation_oid == InvalidOid)
+		return false;
 
 	/* Assume it's a parent */
 	if (has_pathman_relation_info(relation_oid))
