Heal segfault in handle_modification_query.

arssher · arssher · commit 43fd918a8dac · 2019-06-03T12:21:30.000+03:00
To encounter this, you need to parse utility query after entering planning.
diff --git a/src/pg_pathman.c b/src/pg_pathman.c
@@ -1965,6 +1965,7 @@ make_inh_translation_list(Relation oldrelation, Relation newrelation,
 /*
  * set_append_rel_pathlist
  *	  Build access paths for an "append relation"
+ * Similar to PG function with the same name.
  *
  * NOTE: this function is 'public' (used in hooks.c)
  */
diff --git a/src/planner_tree_modification.c b/src/planner_tree_modification.c
@@ -516,7 +516,7 @@ handle_modification_query(Query *parse, transform_query_cxt *context)
 {
 	RangeTblEntry  *rte;
 	Oid				child;
-	Node		   *quals = parse->jointree->quals;
+	Node		   *quals;
 	Index			result_rti = parse->resultRelation;
 	ParamListInfo	params = context->query_params;
 
@@ -525,6 +525,8 @@ handle_modification_query(Query *parse, transform_query_cxt *context)
 							parse->commandType != CMD_DELETE))
 		return;
 
+	/* can't set earlier because CMD_UTILITY doesn't have jointree */
+	quals = parse->jointree->quals;
 	rte = rt_fetch(result_rti, parse->rtable);
 
 	/* Exit if it's ONLY table */

Original file line number	Diff line number	Diff line change
`@@ -1965,6 +1965,7 @@ make_inh_translation_list(Relation oldrelation, Relation newrelation,`
`1965`	`1965`	`/*`
`1966`	`1966`	`* set_append_rel_pathlist`
`1967`	`1967`	`* Build access paths for an "append relation"`
	`1968`	`+ * Similar to PG function with the same name.`
`1968`	`1969`	`*`
`1969`	`1970`	`* NOTE: this function is 'public' (used in hooks.c)`
`1970`	`1971`	`*/`