use DEPENDENCY_NORMAL instead of DEPENDENCY_AUTO (requires DROP CASCADE, but fixes pg_dump)

funbringer · funbringer · commit 82507b669336 · 2017-05-13T17:28:26.000+03:00
diff --git a/expected/pathman_basic.out b/expected/pathman_basic.out
@@ -257,7 +257,7 @@ EXPLAIN (COSTS OFF) SELECT * FROM test.improved_dummy WHERE id = 101 OR id = 5 A
 (5 rows)
 
 DROP TABLE test.improved_dummy CASCADE;
-NOTICE:  drop cascades to 11 other objects
+NOTICE:  drop cascades to 12 other objects
 /* since rel_1_4_beta: check create_range_partitions(bounds array) */
 CREATE TABLE test.improved_dummy (val INT NOT NULL);
 SELECT pathman.create_range_partitions('test.improved_dummy', 'val',
@@ -328,7 +328,7 @@ ORDER BY partition;
 (2 rows)
 
 DROP TABLE test.improved_dummy CASCADE;
-NOTICE:  drop cascades to 2 other objects
+NOTICE:  drop cascades to 3 other objects
 /* Test pathman_rel_pathlist_hook() with INSERT query */
 CREATE TABLE test.insert_into_select(val int NOT NULL);
 INSERT INTO test.insert_into_select SELECT generate_series(1, 100);
@@ -385,7 +385,7 @@ SELECT count(*) FROM test.insert_into_select_copy;
 (1 row)
 
 DROP TABLE test.insert_into_select_copy, test.insert_into_select CASCADE;
-NOTICE:  drop cascades to 5 other objects
+NOTICE:  drop cascades to 6 other objects
 /* Test INSERT hooking with DATE type */
 CREATE TABLE test.insert_date_test(val DATE NOT NULL);
 SELECT pathman.create_partitions_from_range('test.insert_date_test', 'val',
@@ -429,7 +429,7 @@ SELECT max(val) FROM test.insert_date_test; /* check last date */
 (1 row)
 
 DROP TABLE test.insert_date_test CASCADE;
-NOTICE:  drop cascades to 8 other objects
+NOTICE:  drop cascades to 9 other objects
 SET pg_pathman.enable_runtimeappend = OFF;
 SET pg_pathman.enable_runtimemergeappend = OFF;
 VACUUM;
@@ -1454,7 +1454,7 @@ SELECT pathman.split_range_partition('test.zero_50', 60, 'test.zero_60');
 (1 row)
 
 DROP TABLE test.zero CASCADE;
-NOTICE:  drop cascades to 4 other objects
+NOTICE:  drop cascades to 5 other objects
 /*
  * Check that altering table columns doesn't break trigger
  */
@@ -1562,7 +1562,7 @@ NOTICE:  1000 rows copied from test.num_range_rel_3
 
 DROP TABLE test.num_range_rel CASCADE;
 DROP TABLE test.range_rel CASCADE;
-NOTICE:  drop cascades to 9 other objects
+NOTICE:  drop cascades to 10 other objects
 /* Test automatic partition creation */
 CREATE TABLE test.range_rel (
 	id	SERIAL PRIMARY KEY,
@@ -1633,7 +1633,7 @@ SELECT * FROM pathman.pathman_config;
 (1 row)
 
 DROP TABLE test.range_rel CASCADE;
-NOTICE:  drop cascades to 20 other objects
+NOTICE:  drop cascades to 21 other objects
 SELECT * FROM pathman.pathman_config;
  partrel | expr | parttype | range_interval | cooked_expr 
 ---------+------+----------+----------------+-------------
@@ -1795,7 +1795,7 @@ SELECT pathman.create_partitions_from_range('test."RangeRel"', 'dt', '2015-01-01
 (1 row)
 
 DROP TABLE test."RangeRel" CASCADE;
-NOTICE:  drop cascades to 5 other objects
+NOTICE:  drop cascades to 6 other objects
 SELECT * FROM pathman.pathman_config;
       partrel       | expr | parttype | range_interval |                                                      cooked_expr                                                       
 --------------------+------+----------+----------------+------------------------------------------------------------------------------------------------------------------------
@@ -1828,7 +1828,7 @@ SELECT pathman.create_partitions_from_range('test."RangeRel"', 'id', 1, 300, 100
 (1 row)
 
 DROP TABLE test."RangeRel" CASCADE;
-NOTICE:  drop cascades to 3 other objects
+NOTICE:  drop cascades to 4 other objects
 DROP EXTENSION pg_pathman;
 /* Test that everything works fine without schemas */
 CREATE EXTENSION pg_pathman;
@@ -2193,6 +2193,6 @@ ORDER BY partition;
 DROP TABLE test.provided_part_names CASCADE;
 NOTICE:  drop cascades to 2 other objects
 DROP SCHEMA test CASCADE;
-NOTICE:  drop cascades to 38 other objects
+NOTICE:  drop cascades to 42 other objects
 DROP EXTENSION pg_pathman CASCADE;
 DROP SCHEMA pathman CASCADE;
diff --git a/expected/pathman_bgw.out b/expected/pathman_bgw.out
@@ -29,7 +29,7 @@ SELECT * FROM pathman_partition_list ORDER BY partition; /* should contain 3 par
 (3 rows)
 
 DROP TABLE test_bgw.test_1 CASCADE;
-NOTICE:  drop cascades to 3 other objects
+NOTICE:  drop cascades to 4 other objects
 /* int8, size of Datum == 8 */
 CREATE TABLE test_bgw.test_2(val INT8 NOT NULL);
 SELECT create_range_partitions('test_bgw.test_2', 'val', 1, 5, 2);
@@ -54,7 +54,7 @@ SELECT * FROM pathman_partition_list ORDER BY partition; /* should contain 3 par
 (3 rows)
 
 DROP TABLE test_bgw.test_2 CASCADE;
-NOTICE:  drop cascades to 3 other objects
+NOTICE:  drop cascades to 4 other objects
 /* numeric, size of Datum == var */
 CREATE TABLE test_bgw.test_3(val NUMERIC NOT NULL);
 SELECT create_range_partitions('test_bgw.test_3', 'val', 1, 5, 2);
@@ -79,7 +79,7 @@ SELECT * FROM pathman_partition_list ORDER BY partition; /* should contain 3 par
 (3 rows)
 
 DROP TABLE test_bgw.test_3 CASCADE;
-NOTICE:  drop cascades to 3 other objects
+NOTICE:  drop cascades to 4 other objects
 /* date, size of Datum == var */
 CREATE TABLE test_bgw.test_4(val DATE NOT NULL);
 SELECT create_range_partitions('test_bgw.test_4', 'val', '20170213'::date, '1 day'::interval, 2);
@@ -104,6 +104,6 @@ SELECT * FROM pathman_partition_list ORDER BY partition; /* should contain 3 par
 (3 rows)
 
 DROP TABLE test_bgw.test_4 CASCADE;
-NOTICE:  drop cascades to 3 other objects
+NOTICE:  drop cascades to 4 other objects
 DROP SCHEMA test_bgw CASCADE;
 DROP EXTENSION pg_pathman;
diff --git a/expected/pathman_calamity.out b/expected/pathman_calamity.out
@@ -725,7 +725,7 @@ SELECT get_part_range('calamity.test_range_idx', 0, NULL::INT4);	/* OK */
 (1 row)
 
 DROP TABLE calamity.test_range_idx CASCADE;
-NOTICE:  drop cascades to table calamity.test_range_idx_1
+NOTICE:  drop cascades to 2 other objects
 /* check function get_part_range_by_oid() */
 CREATE TABLE calamity.test_range_oid(val INT4 NOT NULL);
 SELECT create_range_partitions('calamity.test_range_oid', 'val', 1, 10, 1);
@@ -747,7 +747,7 @@ SELECT get_part_range('calamity.test_range_oid_1', NULL::INT4);		/* OK */
 (1 row)
 
 DROP TABLE calamity.test_range_oid CASCADE;
-NOTICE:  drop cascades to table calamity.test_range_oid_1
+NOTICE:  drop cascades to 2 other objects
 /* check function merge_range_partitions() */
 SELECT merge_range_partitions('{pg_class}');						/* not ok */
 ERROR:  cannot merge partitions
@@ -771,7 +771,7 @@ SELECT merge_range_partitions('{calamity.merge_test_a_1,
 								calamity.merge_test_b_1}');			/* not ok */
 ERROR:  cannot merge partitions
 DROP TABLE calamity.merge_test_a,calamity.merge_test_b CASCADE;
-NOTICE:  drop cascades to 4 other objects
+NOTICE:  drop cascades to 6 other objects
 /* check function drop_triggers() */
 CREATE TABLE calamity.trig_test_tbl(val INT4 NOT NULL);
 SELECT create_hash_partitions('calamity.trig_test_tbl', 'val', 2);
@@ -990,6 +990,6 @@ EXPLAIN (COSTS OFF) SELECT * FROM calamity.survivor;			/* OK */
 (3 rows)
 
 DROP TABLE calamity.survivor CASCADE;
-NOTICE:  drop cascades to 2 other objects
+NOTICE:  drop cascades to 3 other objects
 DROP SCHEMA calamity CASCADE;
 DROP EXTENSION pg_pathman;
diff --git a/expected/pathman_callbacks.out b/expected/pathman_callbacks.out
@@ -66,7 +66,7 @@ WHERE partrel = 'callbacks.abc'::REGCLASS;
 (1 row)
 
 DROP TABLE callbacks.abc CASCADE;
-NOTICE:  drop cascades to 2 other objects
+NOTICE:  drop cascades to 3 other objects
 /* set callback to be called on RANGE partitions */
 CREATE TABLE callbacks.abc(a serial, b int);
 SELECT create_range_partitions('callbacks.abc', 'a', 1, 100, 2);
@@ -196,7 +196,7 @@ $$ language plpgsql;
 INSERT INTO callbacks.abc VALUES (301, 0); /* +1 new partition */
 WARNING:  callback arg: {"parent": "abc", "parttype": "2", "partition": "abc_5", "range_max": "401", "range_min": "301", "parent_schema": "callbacks", "partition_schema": "callbacks"}
 DROP TABLE callbacks.abc CASCADE;
-NOTICE:  drop cascades to 4 other objects
+NOTICE:  drop cascades to 5 other objects
 /* more complex test using rotation of tables */
 CREATE TABLE callbacks.abc(a INT4 NOT NULL);
 INSERT INTO callbacks.abc
@@ -413,7 +413,7 @@ ORDER BY range_min::INT4;
 (4 rows)
 
 DROP TABLE callbacks.abc CASCADE;
-NOTICE:  drop cascades to 4 other objects
+NOTICE:  drop cascades to 5 other objects
 DROP SCHEMA callbacks CASCADE;
 NOTICE:  drop cascades to 2 other objects
 DROP EXTENSION pg_pathman CASCADE;
diff --git a/expected/pathman_cte.out b/expected/pathman_cte.out
@@ -33,7 +33,7 @@ SELECT * FROM ttt;
 (6 rows)
 
 DROP TABLE test_cte.range_rel CASCADE;
-NOTICE:  drop cascades to 4 other objects
+NOTICE:  drop cascades to 5 other objects
 CREATE TABLE test_cte.hash_rel (
 	id		INT4,
 	value	INTEGER NOT NULL);
@@ -225,7 +225,7 @@ SELECT * FROM test_cte.cte_del_xacts t JOIN tmp ON t.id = tmp.tid;
 
 DROP FUNCTION test_cte.cte_del_xacts_stab(TEXT);
 DROP TABLE test_cte.cte_del_xacts, test_cte.cte_del_xacts_specdata CASCADE;
-NOTICE:  drop cascades to table test_cte.cte_del_xacts_1
+NOTICE:  drop cascades to 2 other objects
 /* Test recursive CTE */
 CREATE TABLE test_cte.recursive_cte_test_tbl(id INT NOT NULL, name TEXT NOT NULL);
 SELECT create_hash_partitions('test_cte.recursive_cte_test_tbl', 'id', 2);
diff --git a/expected/pathman_expressions.out b/expected/pathman_expressions.out
@@ -151,5 +151,5 @@ SELECT COUNT(*) FROM test_exprs.range_rel_2;
 (1 row)
 
 DROP SCHEMA test_exprs CASCADE;
-NOTICE:  drop cascades to 16 other objects
+NOTICE:  drop cascades to 17 other objects
 DROP EXTENSION pg_pathman;
diff --git a/expected/pathman_foreign_keys.out b/expected/pathman_foreign_keys.out
@@ -88,7 +88,7 @@ EXPLAIN (COSTS OFF) SELECT * FROM fkeys.messages;
 (3 rows)
 
 DROP TABLE fkeys.messages, fkeys.replies CASCADE;
-NOTICE:  drop cascades to 2 other objects
+NOTICE:  drop cascades to 3 other objects
 DROP SCHEMA fkeys CASCADE;
 NOTICE:  drop cascades to 2 other objects
 DROP EXTENSION pg_pathman CASCADE;
diff --git a/expected/pathman_inserts.out b/expected/pathman_inserts.out
@@ -866,7 +866,7 @@ DROP TABLE test_inserts.test_gap_2; /* make a gap */
 INSERT INTO test_inserts.test_gap VALUES(15); /* not ok */
 ERROR:  cannot spawn a partition
 DROP TABLE test_inserts.test_gap CASCADE;
-NOTICE:  drop cascades to 2 other objects
+NOTICE:  drop cascades to 3 other objects
 DROP SCHEMA test_inserts CASCADE;
-NOTICE:  drop cascades to 18 other objects
+NOTICE:  drop cascades to 19 other objects
 DROP EXTENSION pg_pathman CASCADE;
diff --git a/expected/pathman_interval.out b/expected/pathman_interval.out
@@ -43,7 +43,7 @@ SELECT partrel, range_interval FROM pathman_config;
 (1 row)
 
 DROP TABLE test_interval.abc CASCADE;
-NOTICE:  drop cascades to 3 other objects
+NOTICE:  drop cascades to 4 other objects
 /* Range partitions for INT4 type */
 CREATE TABLE test_interval.abc (id INT4 NOT NULL);
 SELECT create_range_partitions('test_interval.abc', 'id', 0, 100, 2);
@@ -86,7 +86,7 @@ SELECT partrel, range_interval FROM pathman_config;
 (1 row)
 
 DROP TABLE test_interval.abc CASCADE;
-NOTICE:  drop cascades to 3 other objects
+NOTICE:  drop cascades to 4 other objects
 /* Range partitions for INT8 type */
 CREATE TABLE test_interval.abc (id INT8 NOT NULL);
 SELECT create_range_partitions('test_interval.abc', 'id', 0, 100, 2);
@@ -129,7 +129,7 @@ SELECT partrel, range_interval FROM pathman_config;
 (1 row)
 
 DROP TABLE test_interval.abc CASCADE;
-NOTICE:  drop cascades to 3 other objects
+NOTICE:  drop cascades to 4 other objects
 /* Range partitions for DATE type */
 CREATE TABLE test_interval.abc (dt DATE NOT NULL);
 SELECT create_range_partitions('test_interval.abc', 'dt',
@@ -162,7 +162,7 @@ SELECT partrel, range_interval FROM pathman_config;
 (1 row)
 
 DROP TABLE test_interval.abc CASCADE;
-NOTICE:  drop cascades to 2 other objects
+NOTICE:  drop cascades to 3 other objects
 /* Range partitions for FLOAT4 type */
 CREATE TABLE test_interval.abc (x FLOAT4 NOT NULL);
 SELECT create_range_partitions('test_interval.abc', 'x', 0, 100, 2);
@@ -194,7 +194,7 @@ SELECT set_interval('test_interval.abc', 100);
 (1 row)
 
 DROP TABLE test_interval.abc CASCADE;
-NOTICE:  drop cascades to 2 other objects
+NOTICE:  drop cascades to 3 other objects
 /* Range partitions for FLOAT8 type */
 CREATE TABLE test_interval.abc (x FLOAT8 NOT NULL);
 SELECT create_range_partitions('test_interval.abc', 'x', 0, 100, 2);
@@ -226,7 +226,7 @@ SELECT set_interval('test_interval.abc', 100);
 (1 row)
 
 DROP TABLE test_interval.abc CASCADE;
-NOTICE:  drop cascades to 2 other objects
+NOTICE:  drop cascades to 3 other objects
 /* Range partitions for NUMERIC type */
 CREATE TABLE test_interval.abc (x NUMERIC NOT NULL);
 SELECT create_range_partitions('test_interval.abc', 'x', 0, 100, 2);
@@ -255,7 +255,7 @@ SELECT set_interval('test_interval.abc', 100);
 (1 row)
 
 DROP TABLE test_interval.abc CASCADE;
-NOTICE:  drop cascades to 2 other objects
+NOTICE:  drop cascades to 3 other objects
 /* Hash partitioned table shouldn't accept any interval value */
 CREATE TABLE test_interval.abc (id SERIAL);
 SELECT create_hash_partitions('test_interval.abc', 'id', 3);
diff --git a/expected/pathman_only.out b/expected/pathman_only.out
@@ -238,5 +238,5 @@ WHERE val = (SELECT val FROM ONLY test_only.from_only_test
 (27 rows)
 
 DROP SCHEMA test_only CASCADE;
-NOTICE:  drop cascades to 11 other objects
+NOTICE:  drop cascades to 12 other objects
 DROP EXTENSION pg_pathman;
diff --git a/expected/pathman_permissions.out b/expected/pathman_permissions.out
@@ -227,7 +227,7 @@ ORDER BY attrelid::regclass::text; /* check ACL for each column (+1 partition) *
 (5 rows)
 
 DROP TABLE permissions.dropped_column CASCADE;
-NOTICE:  drop cascades to 5 other objects
+NOTICE:  drop cascades to 6 other objects
 /* Finally reset user */
 RESET ROLE;
 DROP OWNED BY user1;
diff --git a/expected/pathman_runtime_nodes.out b/expected/pathman_runtime_nodes.out
@@ -408,6 +408,6 @@ where id = any (select generate_series(-10, -1)); /* should be empty */
 set enable_hashjoin = on;
 set enable_mergejoin = on;
 DROP SCHEMA test CASCADE;
-NOTICE:  drop cascades to 36 other objects
+NOTICE:  drop cascades to 37 other objects
 DROP EXTENSION pg_pathman CASCADE;
 DROP SCHEMA pathman CASCADE;
diff --git a/expected/pathman_update_trigger.out b/expected/pathman_update_trigger.out
@@ -285,5 +285,5 @@ SELECT count(*) FROM test_update_trigger.test_hash;
 (1 row)
 
 DROP SCHEMA test_update_trigger CASCADE;
-NOTICE:  drop cascades to 17 other objects
+NOTICE:  drop cascades to 18 other objects
 DROP EXTENSION pg_pathman;
diff --git a/expected/pathman_updates.out b/expected/pathman_updates.out
@@ -59,5 +59,5 @@ UPDATE test_updates.test SET b = 0 WHERE val = 101 RETURNING *, tableoid::REGCLA
 (1 row)
 
 DROP SCHEMA test_updates CASCADE;
-NOTICE:  drop cascades to 12 other objects
+NOTICE:  drop cascades to 13 other objects
 DROP EXTENSION pg_pathman;
diff --git a/expected/pathman_utility_stmt.out b/expected/pathman_utility_stmt.out
@@ -224,7 +224,7 @@ SELECT *, tableoid::REGCLASS FROM copy_stmt_hooking.test ORDER BY val;
 
 /* drop modified table */
 DROP TABLE copy_stmt_hooking.test CASCADE;
-NOTICE:  drop cascades to 6 other objects
+NOTICE:  drop cascades to 7 other objects
 /* create table again */
 CREATE TABLE copy_stmt_hooking.test(
 	val int not null,
@@ -280,7 +280,7 @@ SELECT COUNT(*) FROM copy_stmt_hooking.test2;
 (1 row)
 
 DROP SCHEMA copy_stmt_hooking CASCADE;
-NOTICE:  drop cascades to 796 other objects
+NOTICE:  drop cascades to 797 other objects
 /*
  * Test auto check constraint renaming
  */
diff --git a/src/pl_funcs.c b/src/pl_funcs.c
@@ -884,7 +884,7 @@ add_to_pathman_config(PG_FUNCTION_ARGS)
 			ObjectAddressSet(sequence, RelationRelationId, naming_seq);
 
 			/* Now this naming sequence is a "part" of partitioned relation */
-			recordDependencyOn(&sequence, &parent, DEPENDENCY_AUTO);
+			recordDependencyOn(&sequence, &parent, DEPENDENCY_NORMAL);
 		}
 	}
 
