[PGPRO-3725] zero out garbage in append_rel_array if we allocate it.

arssher · arssher · commit 8f68671ad22f · 2020-04-02T21:00:26.000+03:00
Since 1d9056f563f3 (who uses AppendRelInfo* existence as a mark this rel is
child) in 11.7 this led to (known) random segfaults.
diff --git a/src/hooks.c b/src/hooks.c
@@ -498,9 +498,13 @@ pathman_rel_pathlist_hook(PlannerInfo *root,
 			   irange_len * sizeof(RangeTblEntry *));
 
 #if PG_VERSION_NUM >= 110000
-		/* Make sure append_rel_array is wide enough */
+		/*
+		 * Make sure append_rel_array is wide enough; if it hasn't been
+		 * allocated previously, care to zero out [0; current_len) part.
+		 */
 		if (root->append_rel_array == NULL)
-			root->append_rel_array = (AppendRelInfo **) palloc0(0);
+			root->append_rel_array = (AppendRelInfo **)
+				palloc0(current_len * sizeof(AppendRelInfo *));
 		root->append_rel_array =  (AppendRelInfo **)
 			repalloc(root->append_rel_array,
 					 new_len * sizeof(AppendRelInfo *));
