add more sanity checks to pathman_bgw tests

funbringer · funbringer · commit 9a7050562b99 · 2017-10-17T17:49:44.000+03:00
diff --git a/expected/pathman_bgw.out b/expected/pathman_bgw.out
@@ -187,6 +187,7 @@ DECLARE
 	i			int4 := 0; -- protect from endless loop
 BEGIN
 	LOOP
+		-- get total number of processed rows
 		SELECT processed
 		FROM pathman_concurrent_part_tasks
 		WHERE relid = 'test_bgw.conc_part'::regclass
@@ -200,9 +201,12 @@ BEGIN
 
 			ASSERT rows IS NOT NULL;
 
-			-- rows should increase!
-			IF rows_old <= rows THEN
+			IF rows_old = rows THEN
 				i = i + 1;
+			ELSIF rows < rows_old THEN
+				RAISE EXCEPTION 'rows is decreasing: new %, old %', rows, rows_old;
+			ELSIF rows > 500 THEN
+				RAISE EXCEPTION 'processed % rows', rows;
 			END IF;
 		ELSE
 			EXIT; -- exit loop
diff --git a/sql/pathman_bgw.sql b/sql/pathman_bgw.sql
@@ -101,6 +101,7 @@ DECLARE
 	i			int4 := 0; -- protect from endless loop
 BEGIN
 	LOOP
+		-- get total number of processed rows
 		SELECT processed
 		FROM pathman_concurrent_part_tasks
 		WHERE relid = 'test_bgw.conc_part'::regclass
@@ -114,9 +115,12 @@ BEGIN
 
 			ASSERT rows IS NOT NULL;
 
-			-- rows should increase!
-			IF rows_old <= rows THEN
+			IF rows_old = rows THEN
 				i = i + 1;
+			ELSIF rows < rows_old THEN
+				RAISE EXCEPTION 'rows is decreasing: new %, old %', rows, rows_old;
+			ELSIF rows > 500 THEN
+				RAISE EXCEPTION 'processed % rows', rows;
 			END IF;
 		ELSE
 			EXIT; -- exit loop
