[PBCKP-402,PBCKP-354] refix "missing contrecord" detection.

funny-falcon · funny-falcon · commit 24f12d98d986 · 2022-12-13T02:52:18.000+03:00
Error message is translated according to current locale. So we can't
compare it as a string. But `abortedRecPtr` exists exactly for this case,
so we can rely on it.
diff --git a/src/parsexlog.c b/src/parsexlog.c
@@ -1446,7 +1446,7 @@ XLogThreadWorker(void *arg)
 					 * TODO: probably we should abort reading logs at this moment.
 					 * But we continue as we did with bug present in Pg < 15.
 					 */
-					strncmp(errormsg, "missing contrecord", 18) == 0))
+					!XLogRecPtrIsInvalid(xlogreader->abortedRecPtr)))
 			{
 				if (SwitchThreadToNextWal(xlogreader, thread_arg))
 					continue;

Original file line number	Diff line number	Diff line change
`@@ -1446,7 +1446,7 @@ XLogThreadWorker(void *arg)`
`1446`	`1446`	`* TODO: probably we should abort reading logs at this moment.`
`1447`	`1447`	`* But we continue as we did with bug present in Pg < 15.`
`1448`	`1448`	`*/`
`1449`		`- strncmp(errormsg, "missing contrecord", 18) == 0))`
	`1449`	`+ !XLogRecPtrIsInvalid(xlogreader->abortedRecPtr)))`
`1450`	`1450`	`{`
`1451`	`1451`	`if (SwitchThreadToNextWal(xlogreader, thread_arg))`
`1452`	`1452`	`continue;`