use portable unlink in delete_walfiles_in_tli()

gsmolk · gsmolk · commit b0efb76003be · 2019-12-29T02:11:10.000+03:00
diff --git a/src/delete.c b/src/delete.c
@@ -933,7 +933,7 @@ delete_walfiles_in_tli(XLogRecPtr keep_lsn, timelineInfo *tlinfo,
 			}
 
 			/* unlink segment */
-			rc = unlink(wal_file->file.path);
+			rc = fio_unlink(wal_file->file.path, FIO_BACKUP_HOST);
 			if (rc < 0)
 			{
 				/* Missing file is not considered as error condition */
diff --git a/src/utils/file.c b/src/utils/file.c
@@ -816,6 +816,7 @@ int fio_unlink(char const* path, fio_location location)
 		IO_CHECK(fio_write_all(fio_stdout, &hdr, sizeof(hdr)), sizeof(hdr));
 		IO_CHECK(fio_write_all(fio_stdout, path, path_len), path_len);
 
+		// TODO: error is swallowed ?
 		return 0;
 	}
 	else

Original file line number	Diff line number	Diff line change
`@@ -933,7 +933,7 @@ delete_walfiles_in_tli(XLogRecPtr keep_lsn, timelineInfo *tlinfo,`
`933`	`933`	`}`
`934`	`934`
`935`	`935`	`/* unlink segment */`
`936`		`- rc = unlink(wal_file->file.path);`
	`936`	`+ rc = fio_unlink(wal_file->file.path, FIO_BACKUP_HOST);`
`937`	`937`	`if (rc < 0)`
`938`	`938`	`{`
`939`	`939`	`/* Missing file is not considered as error condition */`
Original file line number	Diff line number	Diff line change
`@@ -816,6 +816,7 @@ int fio_unlink(char const* path, fio_location location)`
`816`	`816`	`IO_CHECK(fio_write_all(fio_stdout, &hdr, sizeof(hdr)), sizeof(hdr));`
`817`	`817`	`IO_CHECK(fio_write_all(fio_stdout, path, path_len), path_len);`
`818`	`818`
	`819`	`+ // TODO: error is swallowed ?`
`819`	`820`	`return 0;`
`820`	`821`	`}`
`821`	`822`	`else`