Skip to content

Commit fd73b9c

Browse files
committed
add TODO for WAL parsing
1 parent 09accf7 commit fd73b9c

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

src/parsexlog.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1291,7 +1291,10 @@ RunXLogThreads(const char *archivedir, time_t target_time,
12911291
result = false;
12921292
}
12931293
thread_interrupted = false;
1294-
interrupted = false;
1294+
1295+
// TODO: we must detect difference between actual error (failed to read WAL) and interrupt signal
1296+
// if (interrupted)
1297+
// elog(ERROR, "Interrupted during WAL parsing");
12951298

12961299
/* Release threads here, use thread_args only below */
12971300
pfree(threads);

src/utils/thread.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,10 @@
1111

1212
#include "thread.h"
1313

14+
/*
15+
* Global var used to detect error condition (not signal interrupt!) in threads,
16+
* so if one thread errored out, then others may abort
17+
*/
1418
bool thread_interrupted = false;
1519

1620
#ifdef WIN32

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy