Fix compiler warnings due to new checks in PostgreSQL 16

Marina Polyakova · Marina Polyakova · commit 0138dc7dad68 · 2022-11-21T17:41:45.000+03:00
See the commit 0fe954c28584169938e5c0738cfaa9930ce77577 (Add
-Wshadow=compatible-local to the standard compilation flags) in PostgreSQL 16.

pg_wait_sampling.c: In function ‘pg_wait_sampling_get_current’:
pg_wait_sampling.c:454:42: warning: declaration of ‘params’ shadows a previous
local [-Wshadow=compatible-local]
  454 |                 WaitCurrentContext      *params;
      |                                          ^~~~~~
pg_wait_sampling.c:446:34: note: shadowed declaration is here
  446 |         WaitCurrentContext      *params;
      |                                  ^~~~~~
diff --git a/pg_wait_sampling.c b/pg_wait_sampling.c
@@ -451,7 +451,6 @@ pg_wait_sampling_get_current(PG_FUNCTION_ARGS)
 	{
 		MemoryContext		oldcontext;
 		TupleDesc			tupdesc;
-		WaitCurrentContext 	*params;
 
 		funcctx = SRF_FIRSTCALL_INIT();
 

Original file line number	Diff line number	Diff line change
`@@ -451,7 +451,6 @@ pg_wait_sampling_get_current(PG_FUNCTION_ARGS)`
`451`	`451`	`{`
`452`	`452`	`MemoryContext oldcontext;`
`453`	`453`	`TupleDesc tupdesc;`
`454`		`- WaitCurrentContext *params;`
`455`	`454`
`456`	`455`	`funcctx = SRF_FIRSTCALL_INIT();`
`457`	`456`