From 18088dd4aac69a61454cc79dac74e92f2460e11b Mon Sep 17 00:00:00 2001 From: Valeriy Zainullin Date: Thu, 19 Jun 2025 18:16:01 +0300 Subject: [PATCH] Check collector has started in pg_wait_sampling_reset_profile. The worker might have not started yet or it may never start, because its registration was cancelled due to worker limit. This commit adds a check for NULL value of pgws_collector_hdr->latch. The previous usage in pg_wait_sampling.c has such a check, we should do the same here. --- pg_wait_sampling.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/pg_wait_sampling.c b/pg_wait_sampling.c index f5bd6e0..2640668 100644 --- a/pg_wait_sampling.c +++ b/pg_wait_sampling.c @@ -808,8 +808,26 @@ pg_wait_sampling_reset_profile(PG_FUNCTION_ARGS) { LOCKTAG collectorTag; + /* + * This also guards against the case when the + * extension was not loaded at all, but this + * function was called. pgws_collector_hdr is + * NULL in this case. + */ check_shmem(); + /* The collector may have not started yet (it'd be a + * race condition with background worker startup to + * use latch without a check here). + * Or worse, registration of the worker might have been + * denied, if there are too many workers already. + * This is why we cannot wait for its start with a while + * loop. + */ + if (!pgws_collector_hdr->latch) + ereport(ERROR, (errcode(ERRCODE_INTERNAL_ERROR), + errmsg("pg_wait_sampling collector wasn't started"))); + pgws_init_lock_tag(&queueTag, PGWS_QUEUE_LOCK); LockAcquire(&queueTag, ExclusiveLock, false, false); pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy