Fix error message wordings

petere · petere · commit 009bd237bf6d · 2023-05-17T21:33:47.000+02:00
The original patch for percentrepl.c c96de2c adopted the error messages from basebackup_to_shell, but that uses terminology that doesn't really fit with the new API naming.
diff --git a/src/common/percentrepl.c b/src/common/percentrepl.c
@@ -113,16 +113,16 @@ replace_percent_placeholders(const char *instr, const char *param_name, const ch
 				va_end(ap);
 				if (!found)
 				{
-					/* Unknown escape sequence */
+					/* Unknown placeholder */
 #ifdef FRONTEND
 					pg_log_error("invalid value for parameter \"%s\": \"%s\"", param_name, instr);
-					pg_log_error_detail("String contains unexpected escape sequence \"%c\".", *sp);
+					pg_log_error_detail("String contains unexpected placeholder \"%%%c\".", *sp);
 					exit(1);
 #else
 					ereport(ERROR,
 							errcode(ERRCODE_INVALID_PARAMETER_VALUE),
 							errmsg("invalid value for parameter \"%s\": \"%s\"", param_name, instr),
-							errdetail("String contains unexpected escape sequence \"%c\".", *sp));
+							errdetail("String contains unexpected placeholder \"%%%c\".", *sp));
 #endif
 				}
 			}
