Fix minor memory leaks in psql's tab completion.

tglsfdc · tglsfdc · commit 00cf40328a31 · 2022-07-22T10:53:26.000-04:00
Tang Haiying and Tom Lane Discussion: https://postgr.es/m/OS0PR01MB6113EA19F05E217C823B4CCAFB909@OS0PR01MB6113.jpnprd01.prod.outlook.com
diff --git a/src/bin/psql/tab-complete.c b/src/bin/psql/tab-complete.c
@@ -5159,6 +5159,10 @@ _complete_from_query(const char *simple_query,
 
 		/* Clean up */
 		termPQExpBuffer(&query_buffer);
+		if (schemaname)
+			free(schemaname);
+		if (objectname)
+			free(objectname);
 		free(e_object_like);
 		if (e_schemaname)
 			free(e_schemaname);
diff --git a/src/fe_utils/string_utils.c b/src/fe_utils/string_utils.c
@@ -1227,4 +1227,7 @@ patternToSQLRegex(int encoding, PQExpBuffer dbnamebuf, PQExpBuffer schemabuf,
 			appendPQExpBufferStr(dbnamebuf, curbuf->data);
 		termPQExpBuffer(curbuf);
 	}
+
+	if (want_literal_dbname)
+		termPQExpBuffer(&left_literal);
 }

Original file line number	Diff line number	Diff line change
`@@ -1227,4 +1227,7 @@ patternToSQLRegex(int encoding, PQExpBuffer dbnamebuf, PQExpBuffer schemabuf,`
`1227`	`1227`	`appendPQExpBufferStr(dbnamebuf, curbuf->data);`
`1228`	`1228`	`termPQExpBuffer(curbuf);`
`1229`	`1229`	`}`
	`1230`	`+`
	`1231`	`+ if (want_literal_dbname)`
	`1232`	`+ termPQExpBuffer(&left_literal);`
`1230`	`1233`	`}`