Fix pg_get_constraintdef to cope with NOT VALID constraints

alvherre · alvherre · commit 048417511aef · 2011-06-03T16:05:34.000-04:00
This case was missed when NOT VALID constraints were first introduced in commit 722bf70 by Simon Riggs on 2011-02-08. Among other things, it causes pg_dump to omit the NOT VALID flag when dumping such constraints, which may cause them to fail to load afterwards, if they contained values failing the constraint. Per report from Thom Brown.
diff --git a/src/backend/utils/adt/ruleutils.c b/src/backend/utils/adt/ruleutils.c
@@ -1373,6 +1373,9 @@ pg_get_constraintdef_worker(Oid constraintId, bool fullCommand,
 	if (conForm->condeferred)
 		appendStringInfo(&buf, " INITIALLY DEFERRED");
 
+	if (!conForm->convalidated)
+		appendStringInfoString(&buf, " NOT VALID");
+
 	/* Cleanup */
 	ReleaseSysCache(tup);
 
