Fix misplaced strdup(), which could lead to error messages referencing

tglsfdc · tglsfdc · commit 0ad5e43772fa · 2001-01-06T01:39:01.000Z
deallocated memory later on.
diff --git a/src/pl/plpgsql/src/gram.y b/src/pl/plpgsql/src/gram.y
@@ -4,7 +4,7 @@
  *			  procedural language
  *
  * IDENTIFICATION
- *    $Header: /cvsroot/pgsql/src/pl/plpgsql/src/gram.y,v 1.12 2000/09/05 09:02:18 wieck Exp $
+ *    $Header: /cvsroot/pgsql/src/pl/plpgsql/src/gram.y,v 1.13 2001/01/06 01:39:01 tgl Exp $
  *
  *    This software is copyrighted by Jan Wieck - Hamburg.
  *
@@ -378,13 +378,15 @@ decl_rowtype	: T_ROW
 
 decl_varname	: T_WORD
 		    {
-		        $$.name = plpgsql_tolower(strdup(yytext));
-			$$.lineno  = yylineno;
+				/* name should be malloc'd for use as varname */
+				$$.name = strdup(plpgsql_tolower(yytext));
+				$$.lineno  = yylineno;
 		    }
 		;
 
 decl_renname	: T_WORD
 		    {
+				/* the result must be palloc'd, see plpgsql_ns_rename */
 		        $$ = plpgsql_tolower(yytext);
 		    }
 		;

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@`
`4`	`4`	`* procedural language`
`5`	`5`	`*`
`6`	`6`	`* IDENTIFICATION`
`7`		`- * $Header: /cvsroot/pgsql/src/pl/plpgsql/src/gram.y,v 1.12 2000/09/05 09:02:18 wieck Exp $`
	`7`	`+ * $Header: /cvsroot/pgsql/src/pl/plpgsql/src/gram.y,v 1.13 2001/01/06 01:39:01 tgl Exp $`
`8`	`8`	`*`
`9`	`9`	`* This software is copyrighted by Jan Wieck - Hamburg.`
`10`	`10`	`*`
`@@ -378,13 +378,15 @@ decl_rowtype : T_ROW`
`378`	`378`
`379`	`379`	`decl_varname : T_WORD`
`380`	`380`	`{`
`381`		`- $$.name = plpgsql_tolower(strdup(yytext));`
`382`		`- $$.lineno = yylineno;`
	`381`	`+ /* name should be malloc'd for use as varname */`
	`382`	`+ $$.name = strdup(plpgsql_tolower(yytext));`
	`383`	`+ $$.lineno = yylineno;`
`383`	`384`	`}`
`384`	`385`	`;`
`385`	`386`
`386`	`387`	`decl_renname : T_WORD`
`387`	`388`	`{`
	`389`	`+ /* the result must be palloc'd, see plpgsql_ns_rename */`
`388`	`390`	`$$ = plpgsql_tolower(yytext);`
`389`	`391`	`}`
`390`	`392`	`;`