Fix vcregress.pl's ancient misspelling of --max-connections.

tglsfdc · tglsfdc · commit 0b85fa93e457 · 2021-05-11T19:17:07.000-04:00
I copied the existing spelling of "--max_connections", but that's just wrong :-(. Evidently setting $ENV{MAX_CONNECTIONS} has never actually worked in this script. Given the lack of complaints, it's probably not worth back-patching a fix. Per buildfarm. Discussion: https://postgr.es/m/899209.1620759506@sss.pgh.pa.us
diff --git a/src/tools/msvc/vcregress.pl b/src/tools/msvc/vcregress.pl
@@ -71,7 +71,7 @@
 }
 
 my $maxconn = "";
-$maxconn = "--max_connections=$ENV{MAX_CONNECTIONS}"
+$maxconn = "--max-connections=$ENV{MAX_CONNECTIONS}"
   if $ENV{MAX_CONNECTIONS};
 
 my $temp_config = "";
@@ -109,7 +109,7 @@ sub installcheck_internal
 	# for backwards compatibility, "serial" runs the tests in
 	# parallel_schedule one by one.
 	my $maxconn = $maxconn;
-	$maxconn = "--max_connections=1" if $schedule eq 'serial';
+	$maxconn = "--max-connections=1" if $schedule eq 'serial';
 	$schedule = 'parallel' if $schedule eq 'serial';
 
 	my @args = (
@@ -141,7 +141,7 @@ sub check
 	# for backwards compatibility, "serial" runs the tests in
 	# parallel_schedule one by one.
 	my $maxconn = $maxconn;
-	$maxconn = "--max_connections=1" if $schedule eq 'serial';
+	$maxconn = "--max-connections=1" if $schedule eq 'serial';
 	$schedule = 'parallel' if $schedule eq 'serial';
 
 	InstallTemp();
