Remove useless rebuilding of subPlan list during ExecInitNode. Wouldn't

tglsfdc · tglsfdc · commit 0ee260345524 · 2004-03-02T22:17:34.000Z
have been there to start with, except for overly enthusiastic copy-and-
paste ...
diff --git a/src/backend/executor/execProcnode.c b/src/backend/executor/execProcnode.c
@@ -12,7 +12,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/executor/execProcnode.c,v 1.41 2003/11/29 19:51:48 pgsql Exp $
+ *	  $PostgreSQL: pgsql/src/backend/executor/execProcnode.c,v 1.42 2004/03/02 22:17:34 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -242,16 +242,13 @@ ExecInitNode(Plan *node, EState *estate)
 	 * do this after initializing initPlans, in case their arguments
 	 * contain subPlans (is that actually possible? perhaps not).
 	 */
-	subps = NIL;
 	foreach(subp, result->subPlan)
 	{
 		SubPlanState *sstate = (SubPlanState *) lfirst(subp);
 
 		Assert(IsA(sstate, SubPlanState));
 		ExecInitSubPlan(sstate, estate);
-		subps = lappend(subps, sstate);
 	}
-	result->subPlan = subps;
 
 	/* Set up instrumentation for this node if requested */
 	if (estate->es_instrument)

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@`
`12`	`12`	`*`
`13`	`13`	`*`
`14`	`14`	`* IDENTIFICATION`
`15`		`- * $PostgreSQL: pgsql/src/backend/executor/execProcnode.c,v 1.41 2003/11/29 19:51:48 pgsql Exp $`
	`15`	`+ * $PostgreSQL: pgsql/src/backend/executor/execProcnode.c,v 1.42 2004/03/02 22:17:34 tgl Exp $`
`16`	`16`	`*`
`17`	`17`	`*-------------------------------------------------------------------------`
`18`	`18`	`*/`
`@@ -242,16 +242,13 @@ ExecInitNode(Plan node, EState estate)`
`242`	`242`	`* do this after initializing initPlans, in case their arguments`
`243`	`243`	`* contain subPlans (is that actually possible? perhaps not).`
`244`	`244`	`*/`
`245`		`- subps = NIL;`
`246`	`245`	`foreach(subp, result->subPlan)`
`247`	`246`	`{`
`248`	`247`	`SubPlanState sstate = (SubPlanState ) lfirst(subp);`
`249`	`248`
`250`	`249`	`Assert(IsA(sstate, SubPlanState));`
`251`	`250`	`ExecInitSubPlan(sstate, estate);`
`252`		`- subps = lappend(subps, sstate);`
`253`	`251`	`}`
`254`		`- result->subPlan = subps;`
`255`	`252`
`256`	`253`	`/* Set up instrumentation for this node if requested */`
`257`	`254`	`if (estate->es_instrument)`