Fix incorrect return value in JSON equality function for scalars

michaelpq · michaelpq · commit 1171dbde2dae · 2019-05-13T09:11:50.000+09:00
equalsJsonbScalarValue() uses a boolean as return type, however for one code path -1 gets returned, which is confusing. The origin of the confusion is visibly that this code got copy-pasted from compareJsonbScalarValue() since it has been introduced in d1d50bf. No backpatch, as this is only cosmetic. Author: Rikard Falkeborn Discussion: https://postgr.es/m/CADRDgG7mJnek6HNW13f+LF6V=6gag9PM+P7H5dnyWZAv49aBGg@mail.gmail.com
diff --git a/src/backend/utils/adt/jsonb_util.c b/src/backend/utils/adt/jsonb_util.c
@@ -1318,7 +1318,7 @@ equalsJsonbScalarValue(JsonbValue *aScalar, JsonbValue *bScalar)
 		}
 	}
 	elog(ERROR, "jsonb scalar type mismatch");
-	return -1;
+	return false;
 }
 
 /*

Original file line number	Diff line number	Diff line change
`@@ -1318,7 +1318,7 @@ equalsJsonbScalarValue(JsonbValue aScalar, JsonbValue bScalar)`
`1318`	`1318`	`}`
`1319`	`1319`	`}`
`1320`	`1320`	`elog(ERROR, "jsonb scalar type mismatch");`
`1321`		`- return -1;`
	`1321`	`+ return false;`
`1322`	`1322`	`}`
`1323`	`1323`
`1324`	`1324`	`/*`