Remove reachable call to pg_unreachable().

robertmhaas · robertmhaas · commit 12b964d7815b · 2024-04-04T16:22:11.000-04:00
The loop just before this uses break, not return, so this line is reachable. Commit cafe105 introduced this issue. Jelte Fennema-Nio, reviewed by Tristan Partin Discussion: http://postgr.es/m/CAGECzQTO72jKed5461W8cytV2Msh_e+WUZjOyX_RUQCbjk4LRA@mail.gmail.com
diff --git a/src/bin/psql/command.c b/src/bin/psql/command.c
@@ -3815,8 +3815,6 @@ wait_until_connected(PGconn *conn)
 				pg_unreachable();
 		}
 	}
-
-	pg_unreachable();
 }
 
 void

Original file line number	Diff line number	Diff line change
`@@ -3815,8 +3815,6 @@ wait_until_connected(PGconn *conn)`
`3815`	`3815`	`pg_unreachable();`
`3816`	`3816`	`}`
`3817`	`3817`	`}`
`3818`		`-`
`3819`		`- pg_unreachable();`
`3820`	`3818`	`}`
`3821`	`3819`
`3822`	`3820`	`void`