Change commit_delay to be SUSET for 9.3+

simonat2ndQuadrant · simonat2ndQuadrant · commit 13fe298ca06f · 2013-03-22T12:01:16.000Z
Prior to 9.3 the commit_delay affected only the current user,
whereas now only the group leader waits while holding the
WALWriteLock. Deliberate or accidental settings to a poor
value could seriously degrade performance for all users.
Privileges may be delegated by SECURITY DEFINER functions
for anyone that needs per-user settings in real situations.
Request for change from Peter Geoghegan
diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c
@@ -2042,7 +2042,7 @@ static struct config_int ConfigureNamesInt[] =
 	},
 
 	{
-		{"commit_delay", PGC_USERSET, WAL_SETTINGS,
+		{"commit_delay", PGC_SUSET, WAL_SETTINGS,
 			gettext_noop("Sets the delay in microseconds between transaction commit and "
 						 "flushing WAL to disk."),
 			NULL

Original file line number	Diff line number	Diff line change
`@@ -2042,7 +2042,7 @@ static struct config_int ConfigureNamesInt[] =`
`2042`	`2042`	`},`
`2043`	`2043`
`2044`	`2044`	`{`
`2045`		`- {"commit_delay", PGC_USERSET, WAL_SETTINGS,`
	`2045`	`+ {"commit_delay", PGC_SUSET, WAL_SETTINGS,`
`2046`	`2046`	`gettext_noop("Sets the delay in microseconds between transaction commit and "`
`2047`	`2047`	`"flushing WAL to disk."),`
`2048`	`2048`	`NULL`